Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quicker way to release GAX and google auth library together? #2137

Open
suztomo opened this issue Jul 21, 2021 · 5 comments
Open

Quicker way to release GAX and google auth library together? #2137

suztomo opened this issue Jul 21, 2021 · 5 comments
Labels
p2

Comments

@suztomo
Copy link
Contributor

suztomo commented Jul 21, 2021 •
edited

As of now, when the google auth library provides a new method for GAX, we need to release Google Cloud BOM and the Libraries BOM that contains the newer version of the google auth library. Until that, GAX cannot use the google auth library because Linkage Monitor complains:

googleapis/gax-java#1420 (comment)

Once the Libraries BOM release is done, we can upgrade the google auth library version in GAX.

Is there a better way?

CC: @Neenu1995
@elharo
Copy link
Contributor

elharo commented Jul 21, 2021

How often does this happen? If it's a once a year thing, we might as well just push libraries-bom.

This is also an argument for not necessarily waiting for google-cloud-bom to update the auth-library before libraries-bom does.

@elharo elharo added the p2 label Jul 21, 2021
@suztomo
Copy link
Contributor Author

suztomo commented Jul 21, 2021

Yes, it's rare. For this case, Neenu is going to release the Google Cloud BOM (with new dependencies BOM), and we'll release the Libraries BOM.

I'll record occurrences in this issue in case similar situation happens again.

@suztomo
Copy link
Contributor Author

suztomo commented Jul 21, 2021

Also I'm wondering whether Linkage Monitor is a suitable tool here now. The Libraries BOM now follows the Google Cloud BOM and the shared dependencies BOM.

While Linkage Monitor might find some unexpected dependency problems, the main purpose of finding incompatible dependencies are handled by the full convergence check at java-cloud-bom repository.

(I have not decided anything yet.)

@suztomo suztomo mentioned this issue Jul 30, 2021
Merged
@suztomo suztomo mentioned this issue Aug 23, 2021
Closed
suztomo added a commit to suztomo/synthtool that referenced this issue Aug 23, 2021
@suztomo
ci: removing linkage-monitor from the required checks
2e50f7d 
Linkage Monitor has served to identify the dependency conflicts
between the source tree in a pull request and the latest Libraries
BOM. However the Libraries BOM now implements the process to sync
with the dependencies of the Google Cloud BOM and the Google Cloud
BOM achieves dependency convergence with regard to the shared
dependencies BOM. Therefore, Linkage Monitor does not give much
benefit to our library development process any more.
GoogleCloudPlatform/cloud-opensource-java#2137
This was referenced Aug 24, 2021
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
gcf-merge-on-green bot pushed a commit to googleapis/java-vpcaccess that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#61)
952693b 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-data-fusion that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#41)
c1f7a37 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-essential-contacts that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#84)
675f393 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-analytics-admin that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#270)
1a14cf6 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-channel that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#165)
0229115 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-assured-workloads that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#305)
2569106 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-video-transcoder that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#217)
c9d0459 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-phishingprotection that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#528)
ec33196 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-policy-troubleshooter that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#96)
f6248c1 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-network-security that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#42)
d33242f 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-billingbudgets that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#566)
ebe69a1 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-memcache that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#483)
88f9b83 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-api-gateway that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#120)
e6736bc 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-dataflow that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#44)
87bf4b4 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-service-control that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#43)
79350cb 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-gke-connect-gateway that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#50)
ca14d91 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-resource-settings that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#44)
5e53220 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-gsuite-addons that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#84)
1d15bd3 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-debugger-client that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#50)
48b41ef 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-servicedirectory that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#506)
69e4b42 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-profiler that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#135)
63d0dbd 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-service-usage that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#86)
8c1b98f 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-domains that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#95)
9446926 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-datastream that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#41)
7bfa21a 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
gcf-merge-on-green bot pushed a commit to googleapis/java-container that referenced this issue Aug 24, 2021
@suztomo
ci: removing linkage-monitor from the required checks (#552)
0b6edf9 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
@aristide-n
Copy link

fyi, linkage-monitor check failed for a reason similar to this in googleapis/java-datastore#492

@suztomo
Copy link
Contributor Author

suztomo commented Aug 26, 2021

@aristide-n Yes, as you might already noticed, I've removed the check from the required checks of these repositories. For java-datastore, it's done googleapis/java-datastore#515.

palmere-google pushed a commit to googleapis/java-pubsublite-flink that referenced this issue Sep 20, 2021
@suztomo @palmere-google
ci: removing linkage-monitor from the required checks (#56)
b5dce3b 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
@suztomo
ci: removing linkage-monitor from the required checks (googleapis#606)
d635552 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
github-actions bot pushed a commit to googleapis/google-cloud-java that referenced this issue Jul 1, 2022
@suztomo
ci: removing linkage-monitor from the required checks (#324)
2b72589 
Linkage Monitor is no longer needed, because the Libraries BOM synchronizes with Google Cloud BOM and the shared dependencies BOM GoogleCloudPlatform/cloud-opensource-java#2137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@suztomo @elharo @aristide-n