Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bash/zsh completions #53

Open
Tracked by #151
threepointone opened this issue Nov 29, 2021 · 10 comments
Open
Tracked by #151

bash/zsh completions #53

threepointone opened this issue Nov 29, 2021 · 10 comments
Labels
blocked Blocked on other work enhancement New feature or request

Comments

@threepointone
Copy link
Contributor

We can leverage yargs.completion() to autogenerate bash/zsh completions for wrangler. I tried it, and it's... fine. Annoyingly, it hijacks any suggestions for filenames, and I assume we'll have to reimplement that. Leaving this open if anyone wants a crack at it.
@threepointone threepointone mentioned this issue Dec 21, 2021
Closed
10 tasks
@JacobMGEvans JacobMGEvans self-assigned this Dec 28, 2021
@JacobMGEvans
Copy link
Contributor

JacobMGEvans commented Jan 3, 2022 •
edited

yargs.completion stuff from what I can tell it seems the filename completion not working is fundamental issue with their script they generate for zsh (I use zsh) I was able to get completion to work for the main commands and then the filesystem to autocomplete after the command completions, however, it overrides the flags

I created a ticket on yargs, hopefully get some insight or a potential workaround with the .positional for filename
yargs/yargs#2113

@Electroid Electroid added this to the 2.0 milestone Jan 20, 2022
@Electroid Electroid removed this from the 2.0 milestone Jan 31, 2022
@petebacondarwin petebacondarwin added this to the Wrangler 2.1 milestone Feb 1, 2022
@petebacondarwin petebacondarwin added enhancement New feature or request and removed feature labels May 12, 2022
@petebacondarwin petebacondarwin removed this from the Selected for development milestone May 15, 2022
@threepointone
Copy link
Contributor Author

I don't think this is something we can work on now, it'll take a ton of work to get this to work well for us since yargs doesn't even list files etc. Should probably unassign and move this to backlog.

@petebacondarwin
Copy link
Contributor

I agree. Moving to the backlog...

@penalosa penalosa mentioned this issue Feb 27, 2023
Closed
@DaniFoldi
Copy link
Contributor

In case this gets picked up, could we have fish (https://fishshell.com) added to the list of supported shells?

@RamIdeas
Copy link
Contributor

We won't be able to do anything about this until yargs/yargs#2113 is resolved but there's been no movement there. Closing for now.

@Cherry
Copy link
Contributor

Cherry commented Jul 31, 2023 •
edited

I don't think closing an issue because it's blocked upstream makes a lot of sense...

This is still something that would be good to have, and people want to see, and closing the issue is only going to cause confusion when someone searches for it later and sees it closed as "completed", or this can be addressed down the line. What's the harm in leaving it open and just adding a blocked label or something so it can be easily filtered? cc @admah

@admah admah added the blocked Blocked on other work label Jul 31, 2023
@admah admah reopened this Jul 31, 2023
@alyssadev
Copy link

Completions would certainly be nice to have as a feature. The mentioned upstream blocking issue is implemented by yargs/yargs#2331, just hasn't been merged since May.

@pauliesnug
Copy link

Any update on this?

@alyssadev
Copy link

Blocked by upstream as mentioned

@Lan-Hekary
Copy link

Any news on this front ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Blocked on other work enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests