feat: add config recommended-legacy #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
force-pushed
the
feat/add-legacy-config
branch
2 times, most recently
from
69cf370
to
f729940
Compare
nzakas
requested changes
Dec 14, 2023
aladdin-add
force-pushed
the
feat/add-legacy-config
branch
from
2bee9f1
to
1ad8593
Compare
it also moves rule tests to `./test/rules`, and adds a test for the configs. fixes #131 Signed-off-by: 唯然 <weiran.zsd@outlook.com>
aladdin-add
force-pushed
the
feat/add-legacy-config
branch
from
45f2813
to
5dbc55c
Compare
nzakas
reviewed
Dec 14, 2023
README.md
Outdated
| @@ -70,3 +83,4 @@ npm test | |||
| | [detect-unsafe-regex](docs/rules/detect-unsafe-regex.md) | Detects potentially unsafe regular expressions, which may take a very long time to run, blocking the event loop. | ✅ | | |||
|
|
|||
| <!-- end auto-generated rules list --> | |||
| ```` | |||
There was a problem hiding this comment.
ops, it was auto-gened, will take a look.
There was a problem hiding this comment.
There was an issue with the formatting of the js code block above, which should be fine now.
aladdin-add
force-pushed
the
feat/add-legacy-config
branch
from
114f214
to
88741a3
Compare
nzakas
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it also moves rule tests to
./test/rules/, and adds a test for the configs.fixes #131