{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":4279682,"defaultBranch":"master","name":"fish-shell","ownerLogin":"fish-shell","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-05-10T03:00:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1828073?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1714944068.0","currentOid":""},"activityList":{"items":[{"before":"251ddd1bcca2bf6fa90a24e8735fc477e6dfc84d","after":"02532f8bb8d7529ae0223f61f3874ceeb28b0ab2","ref":"refs/heads/master","pushedAt":"2024-06-09T19:15:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ridiculousfish","name":"Peter Ammon","path":"/ridiculousfish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/920838?s=80&v=4"},"commit":{"message":"Mark that our printf is licensed under MIT","shortMessageHtmlLink":"Mark that our printf is licensed under MIT"}},{"before":"2fa0f13db2a48dc869fc7429db2d2d5e780b6690","after":"251ddd1bcca2bf6fa90a24e8735fc477e6dfc84d","ref":"refs/heads/master","pushedAt":"2024-06-08T07:14:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"Revert \"builtins/path: Use fancy bitflags feature\"\n\nThis builds on my machine, but doesn't on CI.\n\nRust 1.67 possibly needs to derive Eq as well as PartialEq?\n\nThis reverts commit 2fa0f13db2a48dc869fc7429db2d2d5e780b6690.","shortMessageHtmlLink":"Revert \"builtins/path: Use fancy bitflags feature\""}},{"before":"ab0fdd19183054df84544c7b13bff32092f2fcdc","after":"2fa0f13db2a48dc869fc7429db2d2d5e780b6690","ref":"refs/heads/master","pushedAt":"2024-06-08T07:05:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"builtins/path: Use fancy bitflags feature\n\nJust a cleanup TODO, no functional changes intended","shortMessageHtmlLink":"builtins/path: Use fancy bitflags feature"}},{"before":"d317e3638c80a6618d3508d6e984546ef428c16e","after":"ab0fdd19183054df84544c7b13bff32092f2fcdc","ref":"refs/heads/master","pushedAt":"2024-06-06T20:04:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"Remove unescape_string_in_place\n\nOnly used in two places and did not do anything sensible","shortMessageHtmlLink":"Remove unescape_string_in_place"}},{"before":"f59cdfaa8d480d5241c521091b44bd5065019342","after":"d317e3638c80a6618d3508d6e984546ef428c16e","ref":"refs/heads/master","pushedAt":"2024-06-06T14:47:52.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"Update the other dependencies","shortMessageHtmlLink":"Update the other dependencies"}},{"before":"3411b72a6d45714000f0ccabab58aed5e70eae14","after":"f59cdfaa8d480d5241c521091b44bd5065019342","ref":"refs/heads/master","pushedAt":"2024-06-06T14:47:40.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"fish_add_path: Be more informative in verbose mode\n\nOne issue with fish_add_path at the moment is that it is sometimes a bit too intransparent.\n\nYou'll try to add a path, but it won't appear - was that because it wasn't a directory,\nor because it doesn't exist, or because it was already included?\n\nIf it isn't usable after, did fish_add_path not add it because of something or did something *else* remove it?\n\nSo we give more explanations - \"skipping this because it's a file\", \"not setting anything because no paths are left to add\", ...","shortMessageHtmlLink":"fish_add_path: Be more informative in verbose mode"}},{"before":"90bd8cc02b8776ae3f09731286db27b08c8360dd","after":"3411b72a6d45714000f0ccabab58aed5e70eae14","ref":"refs/heads/master","pushedAt":"2024-06-04T20:30:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"Curses: Update the comments","shortMessageHtmlLink":"Curses: Update the comments"}},{"before":"01e958d2fb0e4ba2e1dfcb4a030e1e9520c8f0c7","after":"90bd8cc02b8776ae3f09731286db27b08c8360dd","ref":"refs/heads/master","pushedAt":"2024-06-04T20:14:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"Remove errant .rs2 file","shortMessageHtmlLink":"Remove errant .rs2 file"}},{"before":"9f0e034fadd0a787f675992084d436b421c6ea5c","after":"01e958d2fb0e4ba2e1dfcb4a030e1e9520c8f0c7","ref":"refs/heads/master","pushedAt":"2024-06-03T03:02:06.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"git: add completion for sparse-checkout subcommand (#10542)","shortMessageHtmlLink":"git: add completion for sparse-checkout subcommand (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2328931821\" data-permission-text=\"Title is private\" data-url=\"https://github.com/fish-shell/fish-shell/issues/10542\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/fish-shell/fish-shell/pull/10542/hovercard\" href=\"https://github.com/fish-shell/fish-shell/pull/10542\">#10542</a>)"}},{"before":"d90d924c8cea6e508f64619031db15922c49882e","after":"9f0e034fadd0a787f675992084d436b421c6ea5c","ref":"refs/heads/master","pushedAt":"2024-06-03T02:58:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Fix curl data string from path completions\n\nCloses #10539.","shortMessageHtmlLink":"Fix curl data string from path completions"}},{"before":"abf92fcbd1e049af462a957f8e9af1a01c7bb6b7","after":"d90d924c8cea6e508f64619031db15922c49882e","ref":"refs/heads/master","pushedAt":"2024-06-03T02:49:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Remove parser `library_data_pod_t` ffi workaround\n\nWe don't need to separate POD fields from the main parser libdata any more.","shortMessageHtmlLink":"Remove parser <code>library_data_pod_t</code> ffi workaround"}},{"before":"96faad247f669e9cbfc738e0550b2781308f80f8","after":"abf92fcbd1e049af462a957f8e9af1a01c7bb6b7","ref":"refs/heads/master","pushedAt":"2024-06-02T22:52:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"ridiculousfish","name":"Peter Ammon","path":"/ridiculousfish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/920838?s=80&v=4"},"commit":{"message":"Fix the bind.py tests\n\nErrant newlines were causing extra prompts.","shortMessageHtmlLink":"Fix the bind.py tests"}},{"before":"25ac5bdb49c39c88940d58e4ab7ed77fd0b20762","after":"96faad247f669e9cbfc738e0550b2781308f80f8","ref":"refs/heads/master","pushedAt":"2024-06-02T22:08:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ridiculousfish","name":"Peter Ammon","path":"/ridiculousfish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/920838?s=80&v=4"},"commit":{"message":"Fix the fg.py pexpect test","shortMessageHtmlLink":"Fix the fg.py pexpect test"}},{"before":"15c0313c3329e72b95b153b8e33fc2c8744f337d","after":"25ac5bdb49c39c88940d58e4ab7ed77fd0b20762","ref":"refs/heads/master","pushedAt":"2024-06-02T21:18:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ridiculousfish","name":"Peter Ammon","path":"/ridiculousfish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/920838?s=80&v=4"},"commit":{"message":"Fix the undo pexpect\n\nAdd the missing expect_prompts to reflect where we send newlines.","shortMessageHtmlLink":"Fix the undo pexpect"}},{"before":"28484e249830d7ecb76b9b333f340c94b0844f69","after":"15c0313c3329e72b95b153b8e33fc2c8744f337d","ref":"refs/heads/master","pushedAt":"2024-06-02T21:08:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"ridiculousfish","name":"Peter Ammon","path":"/ridiculousfish","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/920838?s=80&v=4"},"commit":{"message":"Fix pexpect_helper.py prompt regex\n\nThe prompt regex for pexpect was:\n\n```\n    return re.compile(\n        r\"\"\"(?:\\r\\n?|^)   # beginning of line\n            (?:\\x1b[\\d[KB(m]*)* # optional colors\n            (?:\\x1b[\\?2004h) # Bracketed paste\n            (?:\\x1b[>4;1m) # XTerm's modifyOtherKeys\n            (?:\\x1b[>5u) # CSI u with kitty progressive enhancement\n            (?:\\x1b=) # set application keypad mode, so the keypad keys send unique codes\n            (?:\\[.\\]\\ )?  # optional vi mode prompt\n         \"\"\"\n        + (r\"prompt\\ %d>\" % counter)  # prompt with counter\n        + r\"\"\"\n            (?:\\x1b[\\d\\[KB(m]*)* # optional colors\n        \"\"\",\n        re.VERBOSE,\n    )\n```\n\nThis has a terrible bug: an accidentally unescaped bracket here:\n\n    (?:\\x1b[>4;1m) # XTerm's modifyOtherKeys\n           ^\n\nThis bracket then extends throughout the entire regex, and is\naccidentally terminated here:\n\n    (?:\\x1b[\\d\\[KB(m]*)* # optional colors\n                    ^\n\nThus the whole regex is busted; in particular the prompt counters are\nnot being tested correctly.\n\nA second issue is that these escape sequences are not emitted before the\nfirst prompt, so correcting the regex will cause every test to fail.\n\nFix this by ignoring all of the escape sequences and merely look for\nthe \"prompt %d>\" portion.\n\nTHIS DELIBERATELY CAUSES TEST FAILURES.\n\nThe tests were already broken and falsely reported as passing.\nThese will be fixed in followup commits.\n\nGood news is that the tests should become way more reliable after\nthis is fixed - hopefully no more introducing random sleep() calls.","shortMessageHtmlLink":"Fix pexpect_helper.py prompt regex"}},{"before":"ac4080730989fc52d0e8b9a4263dc9a392c23689","after":"28484e249830d7ecb76b9b333f340c94b0844f69","ref":"refs/heads/master","pushedAt":"2024-06-02T08:53:25.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"CHANGELOG: Fix issue mention","shortMessageHtmlLink":"CHANGELOG: Fix issue mention"}},{"before":"2e52d51af29806d7d614e1cb864600b4a394db06","after":"ac4080730989fc52d0e8b9a4263dc9a392c23689","ref":"refs/heads/master","pushedAt":"2024-06-01T18:17:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Reduce explicit `Block` state\n\nThis doesn't have any effect on the size of the struct (due to alignment\nrequirements and padding) but reduces the complexity by turning\nBlock::wants_pop_env into an emergent property dependent on the type rather than\nsomething we have to manually manage.","shortMessageHtmlLink":"Reduce explicit <code>Block</code> state"}},{"before":"0246c938cadd50c373037b44c8c002531a9929a4","after":"2e52d51af29806d7d614e1cb864600b4a394db06","ref":"refs/heads/master","pushedAt":"2024-06-01T18:05:34.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Convert Block::event_blocks to a bool\n\nWe only increment it and check if it's non-zero, we never decrement or check the\nactual count. As such, change it to a bool and bring the size of `Block` down\nfrom 32 to 24 bytes.","shortMessageHtmlLink":"Convert Block::event_blocks to a bool"}},{"before":"6ec09260dd79b108cae68506dcb0b5d2e960134f","after":"0246c938cadd50c373037b44c8c002531a9929a4","ref":"refs/heads/master","pushedAt":"2024-06-01T01:54:28.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Coalesce BlockType::function_call and BlockType::function_call_no_shadow\n\nThere's no need for two separate block types when one is merely a variant of the\nother. This may have been required under C++ but thanks to sum types (rust's\nenums) we don't need to do that any more.","shortMessageHtmlLink":"Coalesce BlockType::function_call and BlockType::function_call_no_shadow"}},{"before":"417e89a4b39f688f34777a97b3fc0bae83df74bb","after":"6ec09260dd79b108cae68506dcb0b5d2e960134f","ref":"refs/heads/master","pushedAt":"2024-05-31T21:22:06.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Changelog: document #5263 and provide workaround\n\n[ci skip]","shortMessageHtmlLink":"Changelog: document <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"370773380\" data-permission-text=\"Title is private\" data-url=\"https://github.com/fish-shell/fish-shell/issues/5263\" data-hovercard-type=\"issue\" data-hovercard-url=\"/fish-shell/fish-shell/issues/5263/hovercard\" href=\"https://github.com/fish-shell/fish-shell/issues/5263\">#5263</a> and provide workaround"}},{"before":"e1ee193822007a64dac1edd82c77eda8ff36eb13","after":"417e89a4b39f688f34777a97b3fc0bae83df74bb","ref":"refs/heads/master","pushedAt":"2024-05-31T02:32:22.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Work around WSLv1 not properly cleaning up stopped orphaned jobs\n\nSee #5263.","shortMessageHtmlLink":"Work around WSLv1 not properly cleaning up stopped orphaned jobs"}},{"before":"98642d307a1aa287418c52934de6200be2000812","after":"e1ee193822007a64dac1edd82c77eda8ff36eb13","ref":"refs/heads/master","pushedAt":"2024-05-30T22:05:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Speed up __fish_make_cache_dir\n\nDon't fork/exec an external process, especially one performing IO, if we don't\nhave to.\n\nThis, in turn, speeds up __fish_source_cached_completions which is rather slow\nunder WSL (and slower than it needs to be on other platforms).","shortMessageHtmlLink":"Speed up __fish_make_cache_dir"}},{"before":"7d77d7aa84a3d025b151c4fcc5cef9ef5d5750df","after":"98642d307a1aa287418c52934de6200be2000812","ref":"refs/heads/master","pushedAt":"2024-05-30T21:15:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Don't use a graphical browser under SSH\n\n...unless X is also being forwarded.\n\nSomeone else will have to figure out the Wayland equivalent (if that even\nexists). Not my monkey, not my circus.","shortMessageHtmlLink":"Don't use a graphical browser under SSH"}},{"before":"0a8fd05bb0b95dc7475037fb62cbf339c2980313","after":"7d77d7aa84a3d025b151c4fcc5cef9ef5d5750df","ref":"refs/heads/master","pushedAt":"2024-05-30T20:55:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Convert more block iteration methods to use iterators","shortMessageHtmlLink":"Convert more block iteration methods to use iterators"}},{"before":"f6200224fc1b655268910e68b2374831c786a34b","after":"0a8fd05bb0b95dc7475037fb62cbf339c2980313","ref":"refs/heads/master","pushedAt":"2024-05-30T20:52:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"faho","name":"Fabian Boehm","path":"/faho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5185367?s=80&v=4"},"commit":{"message":"docs/fish_add_path: Reword description\n\nUse \"directories\" explicitly instead of \"components\" to make it more\nclear that the arguments need to be directories, not files.\n\nAlso a bit on intent and variable scope.","shortMessageHtmlLink":"docs/fish_add_path: Reword description"}},{"before":"b495cffa50bb1442bf19172bf1c8d31bc1abcfe3","after":"f6200224fc1b655268910e68b2374831c786a34b","ref":"refs/heads/master","pushedAt":"2024-05-30T17:50:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Use Iterator::count() to check function stack depth","shortMessageHtmlLink":"Use Iterator::count() to check function stack depth"}},{"before":"a3e0d64e8840afdd4e6a6f22dacb05e1a9722b69","after":"b495cffa50bb1442bf19172bf1c8d31bc1abcfe3","ref":"refs/heads/master","pushedAt":"2024-05-30T17:25:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"fixup! Add workaround for targets with too small a main stack size","shortMessageHtmlLink":"fixup! Add workaround for targets with too small a main stack size"}},{"before":"46f6aa802489342b73782f61d7a669349b4874a3","after":"a3e0d64e8840afdd4e6a6f22dacb05e1a9722b69","ref":"refs/heads/master","pushedAt":"2024-05-30T17:21:02.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Remove usage of `env -u`\n\n`env -u` is not supported on all platforms we support (e.g. macOS/OS X 10.10).\nWe don't need these variables erased, blanked works just fine.","shortMessageHtmlLink":"Remove usage of <code>env -u</code>"}},{"before":"828b88a2128756c13912d558d3291ef779ca0d69","after":"46f6aa802489342b73782f61d7a669349b4874a3","ref":"refs/heads/master","pushedAt":"2024-05-29T19:08:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Update ssh-keygen completions\n\nDon't run `ssh` upon sourcing and don't rely on `ssh -Q` being available.","shortMessageHtmlLink":"Update ssh-keygen completions"}},{"before":"7bf3b57e47835ebdd5feb640db844973132cd0f1","after":"828b88a2128756c13912d558d3291ef779ca0d69","ref":"refs/heads/master","pushedAt":"2024-05-29T18:54:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"mqudsi","name":"Mahmoud Al-Qudsi","path":"/mqudsi","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/606923?s=80&v=4"},"commit":{"message":"Add issue reference to flatpak completion workaround\n\n[ci skip]","shortMessageHtmlLink":"Add issue reference to flatpak completion workaround"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYIHNhQA","startCursor":null,"endCursor":null}},"title":"Activity · fish-shell/fish-shell"}