feat: add WIF docs, add warning for credentials input #141
Conversation
src/main.ts
Outdated
| // Add warning if using credentials | ||
| if (credentials) { | ||
| core.warning( | ||
| '"credentials" input has been deprecated and will be removed in a future release. ' + |
There was a problem hiding this comment.
I don't know if we should say "will be removed in a future release". It would be better to highlight the benefits of using the auth action for now, and then add the "deprecation" in a few releases.
There was a problem hiding this comment.
Removed that bit- I also have a link in there that points to the relevant section in the main readme which expands on the benefits of using auth.
There was a problem hiding this comment.
Okay - I'm just a little worried about using the "deprecated" word here.
There was a problem hiding this comment.
Since we plan to remove this at some point, I think deprecated would encourage more folks to use auth. Happy to switch if you have anything particular in mind.
Co-authored-by: Seth Vargo <seth@sethvargo.com>
src/main.ts
Outdated
| // Add warning if using credentials | ||
| if (credentials) { | ||
| core.warning( | ||
| '"credentials" input has been deprecated and will be removed in a future release. ' + |
There was a problem hiding this comment.
Okay - I'm just a little worried about using the "deprecated" word here.
auth