Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add userinfo.email scope #15

Merged

Conversation

mtmendonca
Copy link
Contributor

Allows GKE RBAC authentication using the provided service account's email instead of its ID.
Based on GKE docs the token used for GKE authentication needs the userinfo.email scope for a ClusterRoleBinding with User: service-accountl@project-.iam.gserviceaccount.com to work, otherwise, the service account's unique ID is required.

@mtmendonca mtmendonca requested a review from a team as a code owner April 5, 2021 15:32
@google-cla
Copy link

google-cla bot commented Apr 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 5, 2021
@github-actions github-actions bot added the Fork label Apr 5, 2021
@mtmendonca
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 5, 2021
Copy link
Contributor

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

@bharathkkb bharathkkb changed the base branch from main to pr-15 April 7, 2021 18:40
@bharathkkb bharathkkb merged commit fb9a333 into google-github-actions:pr-15 Apr 7, 2021
bharathkkb added a commit that referenced this pull request Apr 7, 2021
Co-authored-by: Marcelo Mendonça <mendonca2709@gmail.com>
@mtmendonca mtmendonca deleted the add-userinfo-email-scope branch September 17, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants