Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prohibit calls to it.only and describe.only #499

Merged
merged 1 commit into from Jun 9, 2020
Merged

fix: prohibit calls to it.only and describe.only #499

merged 1 commit into from Jun 9, 2020

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented May 4, 2020 •
edited

Prevent calls to ".only" in mocha tests. Porting upstream from nodeJS-firestore (original PR).

@thebrianchen thebrianchen changed the title fix: prohibit calls for it.only and describe.only fix: prohibit calls to it.only and describe.only May 4, 2020
@thebrianchen
Copy link
Author

thebrianchen commented May 4, 2020 •
edited

cc @JustinBeckwith

JustinBeckwith
JustinBeckwith approved these changes Jun 9, 2020
View reviewed changes
Copy link
Collaborator

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this may be breaking for some, but I'm willing to ship this in a minor because I think it was a regression.

@JustinBeckwith JustinBeckwith merged commit 071c33c into google:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thebrianchen @JustinBeckwith @googlebot