fix(rule): turn off @typescript-eslint/no-var-requires #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a common pattern to
require('package.json')to determine the version # of an application.We do this in all of our auto generated code:
https://github.com/googleapis/nodejs-asset/pull/403/files
Why this rule is a big problem for client libraries
If we switch these
requirestatements toimportstatements, it breaks publication of our libraries, because TypeScript copies thepackage.jsoninto thebuild/folder, which in turn stops npm from publishing assets in that folder.Another argument I'd make against this rule
requireisn't just used for pulling in JavaScript files, it's convenient for loading JSON fixtures other thanpackage.json, .e.g.,test/fixtures/foo.json-- this is a useful pattern in tests which we'd now need to add ignore rules for.