Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .prettierrc.json to include trailingComma: all to match internal Google config #822

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

calebegg
Copy link
Member

fixes #662

@tonycoco
Copy link
Contributor

Can we rebase this? Change looks good to me.

Copy link
Contributor

@tonycoco tonycoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calebegg
Copy link
Member Author

I am not good at git, my brain has been permanently disfigured by fifteen years of using nothing but Piper/Perforce. I think I screwed this up somehow even though I was following a github help page. If you want to help me that's fine, or if you want to just make the change yourself that's fine too. I've spent half an hour on this and I'm quite frustrated.

@calebegg
Copy link
Member Author

Ok I think I fixed it (thanks again for the help!)

@tonycoco
Copy link
Contributor

Note: the commit message needs to follow conventional commits. Can you amend your commit message?

This change will be messy for lots of repos using gts so we should think about bumping the release semver to align.

@calebegg
Copy link
Member Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable more trailing commas, particularly in function parameters and calls
2 participants