Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should eqeqeq ignore nulls? #733

Open
dormeiri opened this issue Oct 5, 2022 · 1 comment
Open

Should eqeqeq ignore nulls? #733

dormeiri opened this issue Oct 5, 2022 · 1 comment
Labels
priority: p2 type: bug

Comments

@dormeiri
Copy link

dormeiri commented Oct 5, 2022 •
edited

The default value for eqeqeq is "always". I would expect it to ignore nulls as suggested in the style guide.

So this line:

gts/.eslintrc.json

Line 14 in 78c51a1

"eqeqeq": "error",

Needs to be:

        "eqeqeq": ["error", "always", {"null": "ignore"}]
@Paiman-Rasoli
Copy link

@sofisl Hi, can I work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dormeiri @sofisl @Paiman-Rasoli