Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gts lint returning exit code 1 when using yarn 4.0.2 #847

Closed
matheusr-ciandt opened this issue Jan 22, 2024 · 10 comments
Closed

Gts lint returning exit code 1 when using yarn 4.0.2 #847

matheusr-ciandt opened this issue Jan 22, 2024 · 10 comments

Comments

@matheusr-ciandt
Copy link

matheusr-ciandt commented Jan 22, 2024

The gts lint command is returning exit code 1 using yarn 4.0.2

➜ yarn --version        
4.0.2
➜ yarn lint 
version: 18

Using npm:

➜ npm run lint    

> <project>@0.0.1 lint
> gts lint

version: 18

/Users/matheusr/Documents/<project>/src/main.ts
  14:1  error  Delete `⏎··⏎`                prettier/prettier
  15:1  error  Trailing spaces not allowed  no-trailing-spaces

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.
@vladavoX
Copy link

Same issue, as of version 5.1.0. At version 5.0.1 it works

yarn --version
3.6.3
yarn lint
version 18

@DMBerlin
Copy link

DMBerlin commented Apr 9, 2024

Lint was failing on a pipeline I had setup on the workflows.

Had to downgrade gts from "5.2.0" to "5.0.1" and it worked.

@linusjf
Copy link

linusjf commented Apr 22, 2024

Same problem here. Why is gts printing 'version 21' and returning exit code 1 when linting? Also, same exit code and printing out error on fixing. Why? (New to gts).

Not with yarn. Running gts as executable installed through npm.

@tonycoco
Copy link
Contributor

Can you send me some steps to reproduce? I'm able to fresh install:

$ yarn init
$ npx gts init
$ yarn lint

Runs without any issues.

@linusjf
Copy link

linusjf commented Apr 24, 2024

I've abandoned my attempt to use gts at the moment. You can try my repo at https://github.com/linusjf/LearnSolidJS to see if you can recreate the problem. The only other thing you might need to know is that eslint was installed globally as ~v9.1.

@tonycoco
Copy link
Contributor

@linusjf I was able to get it running on your repo by:

$ yarn
$ rm eslint.config.cjs
$ npx gts init
$ yarn lint

...works.

@tonycoco
Copy link
Contributor

If I can ask: What version of Node are you running?

$ node -v

@linusjf
Copy link

linusjf commented Apr 24, 2024 via email

@linusjf
Copy link

linusjf commented Apr 24, 2024

@linusjf I was able to get it running on your repo by:

$ yarn
$ rm eslint.config.cjs
$ npx gts init
$ yarn lint

...works.

I'd rather use the new flat-config.

Perhaps, once gts moves to the new config, I'll look at it again.

#830

I'm already using prettier on my files, anyway, via the lint command line script.

@tonycoco
Copy link
Contributor

Once we drop support for older versions of Node, I plan on migrating to the latest ESLint and will provide the flat config in the init. Closing this for now since we are tracking this already in #830

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants