-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests fail on riscv64 ***Exception: Illegal on Milk-V Pioneer #2125
Comments
Runtime detection does not work properly. Disable tests for now to unblock the builders. ref: google/highway#2125
Yes, we detect at runtime, the code is here: https://github.com/google/highway/blob/master/hwy/targets.cc#L621. Thanks, that's a good idea. We'd welcome such a patch with inline asm. |
I have implemented the fix in pull request #2127 that only enables the HWY_RVV target if tail agnostic mode is supported, mask agnostic mode is supported, and the length of a vuint8m1_t vector is at least 16 bytes. |
I think this is now fixed, thank you @johnplatts :) |
We have recently enabled the tests in Alpine Linux. There is a significant number of tests that fails:
This runs on a Milk-V Pioneer machine with a sophgo 2042 processor. This only implements RVV 0.71, which is why the tests fails with illegal instruction.
My question is if the rvv support is enabled runtime? How and where is the runtime detection done? I would expect that the runtime detection would catch this and highway would fall back to the generic implementation.
For ffmpeg we have adapted a runtime test for detecting compliant rvv 1.0 support and I wonder if we can do something similar for highway.
The text was updated successfully, but these errors were encountered: