You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current constraintClass only supports a couple of compactors. The API will parse an input URI into dict, if we specific a URI like "custom:time>123;time<456", from my understanding, the trace resolver won't work properly, since the key "time" in the dict will get overwritten. For example, if you see how the result is parsed: https://github.com/google/perfetto/blob/main/python/perfetto/trace_uri_resolver/resolver.py#L127, my guess is that only 'time<456' will take effect.
I am proposing that we add an additional OP to support ranges. e.g. the op "<>" can be added, so we can specify the above URI like "custom:time<>123,456". Also, the parsed results need to be specified in a list, something like
Feature request: We'd like the URI provided to the trace resolver to support multiple constraints. For example, the current trace URI will not be able to support URIs like 'a>1;a<3', since keys are stored in a dict, and later values will overwrite the previous one. With this change, we can support such cases, because for constraint classes, we are storing their values as an array, where each element will be a constraint object.
The original discussion in #752
Change-Id: I189af4333409e2dba4b891d85d1d83170ff1135f
https://github.com/google/perfetto/blob/main/python/perfetto/trace_uri_resolver/resolver.py#L29
The current constraintClass only supports a couple of compactors. The API will parse an input URI into dict, if we specific a URI like "custom:time>123;time<456", from my understanding, the trace resolver won't work properly, since the key "time" in the dict will get overwritten. For example, if you see how the result is parsed: https://github.com/google/perfetto/blob/main/python/perfetto/trace_uri_resolver/resolver.py#L127, my guess is that only 'time<456' will take effect.
I am proposing that we add an additional OP to support ranges. e.g. the op "<>" can be added, so we can specify the above URI like "custom:time<>123,456". Also, the parsed results need to be specified in a list, something like
Then our customized trace resolver can take it over from there.
Let me know if this makes sense. I can help contribute the code.
The text was updated successfully, but these errors were encountered: