Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Counter unit name not taken into account #754

Closed
facewindu opened this issue Apr 4, 2024 · 2 comments
Closed

Counter unit name not taken into account #754

facewindu opened this issue Apr 4, 2024 · 2 comments

Comments

@facewindu
Copy link

facewindu commented Apr 4, 2024

I'm trying to set some unit names and multipliers to my custom counter tracks like so

TracePacket.newBuilder()
            .setTrustedPacketSequenceId(...)
            .setTrackDescriptor(TrackDescriptor.newBuilder()
                .setUuid(...)
                .setName("AVAIL_MEM")
                .setCounter(CounterDescriptor.newBuilder().setUnitName("foo").setUnitMultiplier(1000))
            )
            .build()

Canary Perfetto displays
image
The multiplier is properly taken into account, but not the unit name. Am I doing something wrong ?

@LalitMaganti
Copy link
Collaborator

LalitMaganti commented Apr 4, 2024

Nothing is wrong, the unit name is just not plumbed through correctly for track event: it was never a huge deal because the UI didn't display units anyway but now it does, we should definitely add support for that.

Patches welcome or otherwise we will get to this at some point.

@LalitMaganti
Copy link
Collaborator

LalitMaganti commented May 17, 2024

#388 actually tracks this already so closing as a dupe.

@LalitMaganti LalitMaganti closed this as not planned Won't fix, can't repro, duplicate, stale May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants