Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poll SwapPss in /proc/smaps_rollup #777

Closed
funfoolsuzi opened this issue May 6, 2024 · 3 comments
Closed

Poll SwapPss in /proc/smaps_rollup #777

funfoolsuzi opened this issue May 6, 2024 · 3 comments

Comments

@funfoolsuzi
Copy link
Contributor

funfoolsuzi commented May 6, 2024

Following up on a previous issue: #490. There is option to poll /proc/smaps_rollup in the process stats probe, but a few fields were left untracked. I'd like to include all available fields especially SwapPss while scan_smaps_rollup is set to true.
Do you think it is a acceptable feature? And if so, if you don't have bandwidth with this can I make a patch for this?

@LalitMaganti
Copy link
Collaborator

I think this should be fine to add if we're already polling the file and it's just a different field we're not reading.

@funfoolsuzi
Copy link
Contributor Author

@LalitMaganti I noticed there is a CI failure in my change: https://android-review.googlesource.com/c/platform/external/perfetto/+/3087006 and I couldn't repro this issue by building the UI.
It looks like it's failure in ts code but my change doesn't touch any ts code.

Any suggestion on resolving the CI failure?

@LalitMaganti
Copy link
Collaborator

It was a preexisting failure, I rebased your CL and reran the CI.

primiano pushed a commit that referenced this issue May 17, 2024
Bug: #777 (comment)
Change-Id: Id2f72de10d700ef122b37c02f2c0fd459a6a3d89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants