Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a recursive message type #449

Open
software-dov opened this issue Sep 3, 2020 · 0 comments
Open

Add a recursive message type #449

software-dov opened this issue Sep 3, 2020 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@software-dov
Copy link
Contributor

A bug in gapic-generator-python recently emerged due to recursive message types: googleapis/gapic-generator-python#585

Hand testing indicates that the issue is solved, but regressions may be possible, and other generators may not .
Constructing recursive message types in unit tests is complicated and unergonomic due to the protobuf descriptor interface. Having a test possible via showcase would ameliorate the issue.
@software-dov software-dov added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Sep 3, 2020
@software-dov software-dov mentioned this issue Sep 3, 2020
Merged
@vam-google vam-google added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@software-dov @vam-google