Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove forced dependency on main google-cloud-go module #2559

Open
noahdietz opened this issue Apr 30, 2024 · 2 comments
Open

deps: remove forced dependency on main google-cloud-go module #2559

noahdietz opened this issue Apr 30, 2024 · 2 comments
Assignees
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@noahdietz
Copy link
Contributor

We need to force a dependency on the cloud.google.com/go main module to ensure that the module is resolved unambiguously. The issue encountered in #2543 and present in #2552 (see below) is odd though because we have other dependencies with newer, unambiguous dependencies on this module. These should win out during dep resolution, but they aren't for some reason.

Forcing a direct dep on the module resolves the ambiguity but is not an ideal solution.

/root/go/pkg/mod/cloud.google.com/go/auth@v0.3.0/internal/internal.go:31:2: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
	cloud.google.com/go v0.26.0 (/root/go/pkg/mod/cloud.google.com/go@v0.26.0/compute/metadata)
	cloud.google.com/go/compute/metadata v0.3.0 (/root/go/pkg/mod/cloud.google.com/go/compute/metadata@v0.3.0) (compile)
@noahdietz noahdietz added the type: cleanup An internal cleanup or hygiene concern. label Apr 30, 2024
@quartzmo
Copy link
Member

we have other dependencies with newer, unambiguous dependencies on this module

Can you explicitly document what these are?

@noahdietz
Copy link
Contributor Author

we have other dependencies with newer, unambiguous dependencies on this module

Can you explicitly document what these are?

At HEAD before forcing the dep:

$ go mod graph | grep ' cloud.google.com/go@'

cloud.google.com/go/compute@v1.20.1 cloud.google.com/go@v0.110.2
cloud.google.com/go/compute@v1.24.0 cloud.google.com/go@v0.112.0
google.golang.org/genproto@v0.0.0-20240227224415-6ceb2ff114de cloud.google.com/go@v0.112.0
google.golang.org/genproto@v0.0.0-20240125205218-1f4bbc51befe cloud.google.com/go@v0.112.0
cloud.google.com/go/accesscontextmanager@v1.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/aiplatform@v1.60.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/apigateway@v1.6.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/apigeeregistry@v0.8.3 cloud.google.com/go@v0.111.0
cloud.google.com/go/appengine@v1.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/artifactregistry@v1.14.7 cloud.google.com/go@v0.111.0
cloud.google.com/go/asset@v1.17.2 cloud.google.com/go@v0.112.0
cloud.google.com/go/assuredworkloads@v1.11.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/automl@v1.13.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/baremetalsolution@v1.2.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/batch@v1.8.0 cloud.google.com/go@v0.111.0
cloud.google.com/go/beyondcorp@v1.0.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/bigquery@v1.59.1 cloud.google.com/go@v0.112.0
cloud.google.com/go/certificatemanager@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/channel@v1.17.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/cloudbuild@v1.15.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/clouddms@v1.7.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/contactcenterinsights@v1.13.0 cloud.google.com/go@v0.111.0
cloud.google.com/go/container@v1.31.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/containeranalysis@v0.11.4 cloud.google.com/go@v0.112.0
cloud.google.com/go/datacatalog@v1.19.3 cloud.google.com/go@v0.111.0
cloud.google.com/go/datafusion@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/datalabeling@v0.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/dataplex@v1.14.2 cloud.google.com/go@v0.112.0
cloud.google.com/go/dataproc/v2@v2.4.0 cloud.google.com/go@v0.111.0
cloud.google.com/go/datastore@v1.15.0 cloud.google.com/go@v0.110.7
cloud.google.com/go/datastream@v1.10.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/deploy@v1.17.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/dialogflow@v1.49.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/documentai@v1.25.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/domains@v0.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/edgecontainer@v1.1.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/errorreporting@v0.3.0 cloud.google.com/go@v0.105.0
cloud.google.com/go/eventarc@v1.13.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/filestore@v1.8.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/firestore@v1.14.0 cloud.google.com/go@v0.110.2
cloud.google.com/go/functions@v1.16.0 cloud.google.com/go@v0.111.0
cloud.google.com/go/gkebackup@v1.3.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/gkehub@v0.14.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/gkemulticloud@v1.1.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/iam@v1.1.6 cloud.google.com/go@v0.112.0
cloud.google.com/go/ids@v1.4.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/lifesciences@v0.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/logging@v1.9.0 cloud.google.com/go@v0.110.8
cloud.google.com/go/longrunning@v0.5.5 cloud.google.com/go@v0.112.0
cloud.google.com/go/managedidentities@v1.6.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/memcache@v1.10.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/metastore@v1.13.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/monitoring@v1.18.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/networkconnectivity@v1.14.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/networkmanagement@v1.9.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/networksecurity@v0.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/notebooks@v1.11.3 cloud.google.com/go@v0.111.0
cloud.google.com/go/optimization@v1.6.3 cloud.google.com/go@v0.111.0
cloud.google.com/go/orchestration@v1.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/osconfig@v1.12.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/pubsub@v1.36.1 cloud.google.com/go@v0.112.0
cloud.google.com/go/pubsublite@v1.8.1 cloud.google.com/go@v0.110.0
cloud.google.com/go/recommendationengine@v0.8.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/redis@v1.14.2 cloud.google.com/go@v0.111.0
cloud.google.com/go/resourcemanager@v1.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/retail@v1.16.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/run@v1.3.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/security@v1.15.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/securitycenter@v1.24.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/shell@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/spanner@v1.57.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/speech@v1.21.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/storagetransfer@v1.10.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/talent@v1.6.6 cloud.google.com/go@v0.111.0
cloud.google.com/go/texttospeech@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/tpu@v1.6.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/translate@v1.10.1 cloud.google.com/go@v0.112.0
cloud.google.com/go/video@v1.20.4 cloud.google.com/go@v0.111.0
cloud.google.com/go/videointelligence@v1.11.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/vision/v2@v2.8.0 cloud.google.com/go@v0.112.0
cloud.google.com/go/vmmigration@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/vmwareengine@v1.1.1 cloud.google.com/go@v0.111.0
cloud.google.com/go/vpcaccess@v1.7.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/webrisk@v1.9.5 cloud.google.com/go@v0.111.0
cloud.google.com/go/workflows@v1.12.4 cloud.google.com/go@v0.111.0
google.golang.org/grpc@v1.19.0 cloud.google.com/go@v0.26.0
google.golang.org/grpc@v1.23.0 cloud.google.com/go@v0.26.0

gcf-merge-on-green bot pushed a commit that referenced this issue Apr 30, 2024
Force dependency on `cloud.google.com/go` main module to resolve ambiguity.

Fixes #2543
Updates #2559
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 30, 2024
🤖 I have created a release *beep* *boop*
---


## [0.177.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.176.1...v0.177.0) (2024-04-30)


### Features

* **all:** Auto-regenerate discovery clients ([#2548](https://togithub.com/googleapis/google-api-go-client/issues/2548)) ([32a5d10](https://togithub.com/googleapis/google-api-go-client/commit/32a5d10b1870bacb93fdf065e5ce7923c04039e8))
* **all:** Auto-regenerate discovery clients ([#2550](https://togithub.com/googleapis/google-api-go-client/issues/2550)) ([f9bf96d](https://togithub.com/googleapis/google-api-go-client/commit/f9bf96df3a9a7ee9eb5b4b01c60d50f4c70e45c9))
* **all:** Auto-regenerate discovery clients ([#2551](https://togithub.com/googleapis/google-api-go-client/issues/2551)) ([4418f5f](https://togithub.com/googleapis/google-api-go-client/commit/4418f5fc551ce9a1edda277ddf483f3dd596d9aa))
* **all:** Auto-regenerate discovery clients ([#2553](https://togithub.com/googleapis/google-api-go-client/issues/2553)) ([2f46e14](https://togithub.com/googleapis/google-api-go-client/commit/2f46e14ff3836ec2ed0e9b08c33b3ec3d29e707b))
* **all:** Auto-regenerate discovery clients ([#2556](https://togithub.com/googleapis/google-api-go-client/issues/2556)) ([fb153c0](https://togithub.com/googleapis/google-api-go-client/commit/fb153c030eb62f149abff30e6948ea1933a9034c))
* Reduce code size by 29% ([#2544](https://togithub.com/googleapis/google-api-go-client/issues/2544)) ([2f2505b](https://togithub.com/googleapis/google-api-go-client/commit/2f2505b83d909fafc4dcf24aff9bb6eb3b7333d7))


### Bug Fixes

* Split large compute file up ([#2546](https://togithub.com/googleapis/google-api-go-client/issues/2546)) ([1b6db6c](https://togithub.com/googleapis/google-api-go-client/commit/1b6db6c4446668599f8db8edda2dde85d7b6015d))
* Temp patch cloud.google.com/go ambiguity ([#2560](https://togithub.com/googleapis/google-api-go-client/issues/2560)) ([3eb92f1](https://togithub.com/googleapis/google-api-go-client/commit/3eb92f1acf25ec8ac4eeb0fa75dbb04a10db36e0)), refs [#2543](https://togithub.com/googleapis/google-api-go-client/issues/2543) [#2559](https://togithub.com/googleapis/google-api-go-client/issues/2559)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

3 participants