Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow AwsCredentials/ExternalAccountCredentials to take in customized environmentProvider #1032

Open
hlf0319 opened this issue Sep 29, 2022 · 0 comments
Open

Allow AwsCredentials/ExternalAccountCredentials to take in customized environmentProvider #1032

hlf0319 opened this issue Sep 29, 2022 · 0 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@hlf0319
Copy link

hlf0319 commented Sep 29, 2022 •
edited

Is your feature request related to a problem? Please describe.
I'm always frustrated when I want to use my own temporary (AWS) credentials to fetch jwt. The only way to pass in my own environmentProvider is through the System env right now. But I want to rotate the info inside environmentProvider over the time, setting System env is not a great choice.
EnvironmentProvider interface provided by the lib is package level so I could not implement my own and pass in.

Describe the solution you'd like
Expose EnvironmentProvider and allow me to pass in my own implementation of it to AwsCredentials/ExternalAccountCredentials.
@clundin25 clundin25 added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 8, 2022
@Gianlo98 Gianlo98 mentioned this issue May 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hlf0319 @clundin25