Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Workforce Pools #729

Merged
merged 7 commits into from Sep 21, 2021
Merged

feat: add support for Workforce Pools #729

merged 7 commits into from Sep 21, 2021

Conversation

lsirac
Copy link
Collaborator

@lsirac lsirac commented Sep 7, 2021

See go/workforce-pools-client-support.

@lsirac lsirac requested a review from a team as a code owner September 7, 2021 18:32
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2021
@TimurSadykov
Copy link
Member

@lsirac unrelated to this feature, but I see there is a transportFactoryClassName that is never used. Is it expected?

Copy link
Member

@TimurSadykov TimurSadykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question on whether we need to expose those workforce pool methods?

@lsirac lsirac merged commit 5f3fed7 into googleapis:master Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants