diff --git a/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java b/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java index b6366e1fcb..60e8cacb71 100644 --- a/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java +++ b/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableChannelPrimer.java @@ -24,7 +24,9 @@ import com.google.api.gax.grpc.ChannelPrimer; import com.google.api.gax.grpc.GrpcTransportChannel; import com.google.api.gax.rpc.FixedTransportChannelProvider; +import com.google.api.gax.rpc.UnaryCallable; import com.google.auth.Credentials; +import com.google.cloud.bigtable.data.v2.models.DefaultRowAdapter; import com.google.cloud.bigtable.data.v2.models.Query; import com.google.cloud.bigtable.data.v2.models.Row; import com.google.common.base.Preconditions; @@ -143,8 +145,10 @@ private void sendPrimeRequests(ManagedChannel managedChannel) throws IOException // Prime all of the table ids in parallel for (String tableId : tableIds) { + UnaryCallable callable = stub.createReadRowRawCallable(new DefaultRowAdapter()); + ApiFuture f = - stub.readRowRawCallable() + callable .futureCall(Query.create(tableId).rowKey(PRIMING_ROW_KEY).filter(FILTERS.block())); primeFutures.put(tableId, f); diff --git a/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java b/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java index ee0da95070..11bb974eb5 100644 --- a/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java +++ b/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/EnhancedBigtableStub.java @@ -132,7 +132,6 @@ public class EnhancedBigtableStub implements AutoCloseable { private final ServerStreamingCallable readRowsCallable; private final UnaryCallable readRowCallable; - private final UnaryCallable readRowRawCallable; private final UnaryCallable> sampleRowKeysCallable; private final UnaryCallable mutateRowCallable; private final UnaryCallable bulkMutateRowsCallable; @@ -268,7 +267,6 @@ public EnhancedBigtableStub(EnhancedBigtableStubSettings settings, ClientContext readRowsCallable = createReadRowsCallable(new DefaultRowAdapter()); readRowCallable = createReadRowCallable(new DefaultRowAdapter()); - readRowRawCallable = createReadRowRawCallable(new DefaultRowAdapter()); sampleRowKeysCallable = createSampleRowKeysCallable(); mutateRowCallable = createMutateRowCallable(); bulkMutateRowsCallable = createBulkMutateRowsCallable(); @@ -332,11 +330,19 @@ public ServerStreamingCallable createReadRowsCallable( /** * Creates a callable chain to handle point ReadRows RPCs. The chain will: * - * + *
    + *
  • Convert a {@link Query} into a {@link com.google.bigtable.v2.ReadRowsRequest} and + * dispatch the RPC. + *
  • Upon receiving the response stream, it will merge the {@link + * com.google.bigtable.v2.ReadRowsResponse.CellChunk}s in logical rows. The actual row + * implementation can be configured in by the {@code rowAdapter} parameter. + *
  • Retry/resume on failure. + *
  • Filter out marker rows. + *
* *

NOTE: the caller is responsible for adding tracing & metrics.

*/ - public UnaryCallable createReadRowRawCallable(RowAdapter rowAdapter) { + protected UnaryCallable createReadRowRawCallable(RowAdapter rowAdapter) { ServerStreamingCallable readRowsCallable = createReadRowsBaseCallable( ServerStreamingCallSettings.newBuilder() @@ -793,10 +799,6 @@ public UnaryCallable readRowCallable() { return readRowCallable; } - public UnaryCallable readRowRawCallable() { - return readRowRawCallable; - } - public UnaryCallable> sampleRowKeysCallable() { return sampleRowKeysCallable; }