deps: migrate to mockito-core 3.12.4 #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigtable
google-cla
bot
added
the
cla: yes
kolea2
changed the title
kolea2
added
kokoro:force-run
eaball35
added
automerge
gcf-owl-bot
bot
removed
the
owlbot:run
eaball35
approved these changes
Sep 14, 2021
eaball35
removed
the
automerge
yoshi-kokoro
removed
the
kokoro:force-run
igorbernstein2
approved these changes
Sep 14, 2021
| Timestamp startTime = Timestamp.newBuilder().setSeconds(1234).build(); | ||
| Timestamp endTime = Timestamp.newBuilder().setSeconds(5678).build(); | ||
| String operationName = "my-operation"; | ||
| RestoreTableRequest req = RestoreTableRequest.of(CLUSTER_ID, BACKUP_ID).setTableId(TABLE_ID); | ||
| Mockito.when(mockRestoreTableCallable.futureCall(req.toProto(PROJECT_ID, INSTANCE_ID))) |
There was a problem hiding this comment.
a bit confused why this can be removed?
There was a problem hiding this comment.
It seems the only mock actually used in this test was mockRestoreTableOperationCallable. This was getting flagged as unused in a warning.
There was a problem hiding this comment.
oh it seems like its a duplicate of mockOperationResult below
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 22, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.1.3](https://www.github.com/googleapis/java-bigtable/compare/v2.1.2...v2.1.3) (2021-09-21) ### Dependencies * migrate to mockito-core 3.12.4 ([#1008](https://www.github.com/googleapis/java-bigtable/issues/1008)) ([d9f19db](https://www.github.com/googleapis/java-bigtable/commit/d9f19db82f82615e4476462f9c34da7841169838)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.2.1 ([#1010](https://www.github.com/googleapis/java-bigtable/issues/1010)) ([a54a021](https://www.github.com/googleapis/java-bigtable/commit/a54a02135f30e3337812938f5794b293ee6535c6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update mockito-all to mockito-core and use the latest version