Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the usage of BaseApiTracer and BaseApiTracerFactory with ApiTracer and ApiTracerFactory #2210

Open
blakeli0 opened this issue Apr 22, 2024 · 0 comments
Open

Replace the usage of BaseApiTracer and BaseApiTracerFactory with ApiTracer and ApiTracerFactory #2210

blakeli0 opened this issue Apr 22, 2024 · 0 comments
Labels
api: bigtable Issues related to the googleapis/java-bigtable API.

Comments

@blakeli0
Copy link
Contributor

blakeli0 commented Apr 22, 2024 •
edited

As part of the OpenTelemetry metrics project, we made all methods in ApiTracer default in this PR. Since BaseApiTracer was originally introduced for Java 7 compatibility and we dropped Java 7 support now, we can replace the usage of BaseApiTracer and BaseApiTracerFactory with ApiTracer and ApiTracerFactory.
For example, make BigtableTracer implements ApiTracer instead of extending from BaseApiTracer.
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/java-bigtable API. label Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blakeli0