Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow samples tests to run concurrently #713

Open
igorbernstein2 opened this issue Apr 9, 2021 · 1 comment
Open

Allow samples tests to run concurrently #713

igorbernstein2 opened this issue Apr 9, 2021 · 1 comment
Assignees
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@igorbernstein2
Copy link
Contributor

It seems like the current samples tests hardcode their resource ids. Which makes them clobber each other when the tests are run concurrently (ie. multiple PRs are open).

We should mitigate this by either:

  1. using the same strategy as the general integration tests and using timestamped resource names
  2. update kokoro to take a lock for the samples tests

I would prefer 1

@igorbernstein2 igorbernstein2 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Apr 9, 2021
@product-auto-label product-auto-label bot added api: bigtable Issues related to the googleapis/java-bigtable API. samples Issues that are directly related to samples. labels Apr 9, 2021
@billyjacobson
Copy link
Contributor

The table and instance admin tests create all new resources and the reads/filters/writes tests use the same instance but create tables with dynamically generated names. There isn't anything too intense going on in any of these tests though, so it shouldn't be having issues. Let me know if there are some specific instances you've seen.

I like having tests use a pre-existing instance since it is faster and doesn't run into issues with instances not being deleted and having dozens of unused nodes in random projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants