Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Public Access Prevention "unspecified" to "inherited" #1047

Closed
shaffeeullah opened this issue Sep 27, 2021 · 1 comment
Closed

Change Public Access Prevention "unspecified" to "inherited" #1047

shaffeeullah opened this issue Sep 27, 2021 · 1 comment
Labels
api: storage Issues related to the googleapis/java-storage API.

Comments

@shaffeeullah
Copy link

shaffeeullah commented Sep 27, 2021

GCS is changing the unspecified public access prevention value to inherited.

This will require the following changes:

  1. Modify the values in the library. Constants/enum values for unspecified: these should be marked as deprecated. They can stay in the library if deletion would constitute a breaking change
  2. Update the system tests.
  3. Create a new sample with region tag public_access_prevention_inherited. So we don't break any documentation links, please do not delete the unspecified sample or sample test from your repo at this point in time.

Please see nodejs example here: https://github.com/googleapis/nodejs-storage/pull/1614/files

Please wait for approval from myself or @tritone before merging or releasing this change so we can coordinate around release dates. New inherited value should be rolled out to allowlisted testing projects this coming week; should be at 100% by 9/30

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Sep 27, 2021
@BenWhitehead
Copy link
Collaborator

fixed by #1051 staged to release with #1052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API.
Projects
None yet
Development

No branches or pull requests

2 participants