Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start/end types in GetRowsOptions #1124

Open
GuillaumeCisco opened this issue Jul 11, 2022 · 1 comment
Open

start/end types in GetRowsOptions #1124

GuillaumeCisco opened this issue Jul 11, 2022 · 1 comment
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@GuillaumeCisco
Copy link

nodejs-bigtable/src/table.ts

Line 249 in 752a6e7

start?: string;

Looks like type is incorrect.
It can be either a string or an object {value: string, inclusive: bool }

See examples: https://cloud.google.com/nodejs/docs/reference/bigtable/latest/bigtable/table
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the googleapis/nodejs-bigtable API. label Jul 11, 2022
@danieljbruce
Copy link
Contributor

Where do you see this in the examples?

@danieljbruce danieljbruce added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 20, 2022
@Mariatta Mariatta added the samples Issues that are directly related to samples. label Nov 28, 2022
@danieljbruce danieljbruce self-assigned this Feb 9, 2023
@danieljbruce danieljbruce added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Feb 9, 2023
@danieljbruce danieljbruce removed their assignment Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/nodejs-bigtable API. priority: p3 Desirable enhancement or fix. May not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GuillaumeCisco @Mariatta @danieljbruce