Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove samples/to_dataframe/main_test.py #225

Closed
tswast opened this issue Jun 30, 2021 · 0 comments · Fixed by #246
Closed

remove samples/to_dataframe/main_test.py #225

tswast opened this issue Jun 30, 2021 · 0 comments · Fixed by #246
Assignees
@tswast
Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Contributor

tswast commented Jun 30, 2021

As of #224, these samples are redundant.

Blocked until https://cloud.google.com/bigquery/docs/bigquery-storage-python-pandas#objectives is updated.
@product-auto-label product-auto-label bot added api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. samples Issues that are directly related to samples. labels Jun 30, 2021
@tswast tswast added type: process A process-related concern. May include testing, release, or the like. and removed api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. samples Issues that are directly related to samples. labels Jun 30, 2021
@product-auto-label product-auto-label bot added api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. samples Issues that are directly related to samples. labels Jul 1, 2021
@tswast tswast self-assigned this Jul 7, 2021
@tswast tswast mentioned this issue Jul 23, 2021
Merged
4 tasks
@tswast tswast mentioned this issue Aug 9, 2021
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 11, 2021
@tswast
chore: remove unused samples (#268)
d10a216 
Follow-up to #225

I noticed we didn't need several of these samples now that BQ Storage API is used by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquerystorage Issues related to the googleapis/python-bigquery-storage API. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove duplicate code samples tswast/python-bigquery-storage
1 participant
@tswast