Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you support Spanner Async Client? #249

Open
maxpz opened this issue Sep 25, 2022 · 4 comments
Open

Do you support Spanner Async Client? #249

maxpz opened this issue Sep 25, 2022 · 4 comments
Assignees
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@maxpz
Copy link

maxpz commented Sep 25, 2022

Hi Everyone!

Does the current version support the Google Spanner Async Client? https://cloud.google.com/python/docs/reference/spanner/latest/google.cloud.spanner_v1.services.spanner.SpannerAsyncClient

If not. Are there plans to support it? I think it would be a great feature to have.

@maxpz maxpz added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Sep 25, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Sep 25, 2022
@IlyaFaer
Copy link
Contributor

Hello, @maxpz,

Python Spanner client supports async client:
https://github.com/googleapis/python-spanner/blob/451c8ebfb576d1347f0f0fb90921d5ce3abf4730/google/cloud/spanner_v1/services/spanner/async_client.py

sqlalchemy_spanner is built on top of the Python Spanner client. Thus, yes, it's possible and we're going to support it, but I don't think we have straight ETAs yet.

@asthamohta, looks like a related samples PR is stuck, by the way:
googleapis/python-spanner#758

Probably async client can be added inside the Connection class as an immutable parameter. Meaning, a connection uses one client - there should be no way to change async/non-async mode after a connection is created.

@maxpz
Copy link
Author

maxpz commented Sep 27, 2022

Hi @IlyaFaer,

Thanks so much for your quick response. Great news that you are planning to support it! We'll be looking forward to using it. Please let me know if we can help with some testing.

@wray27
Copy link

wray27 commented Nov 22, 2023

Hi @IlyaFaer, any updates on this?

@taua-almeida
Copy link

Any updates on this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

No branches or pull requests

6 participants