Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: drop table compiler quoatation bug #350

Closed
wants to merge 1 commit into from
Closed

fix: drop table compiler quoatation bug #350

wants to merge 1 commit into from

Conversation

rkawajiri
Copy link

@rkawajiri rkawajiri commented Oct 19, 2023 •
edited

Fixes #349

  • Tests pass
    • lint (same error as main branch)
    • unit
    • migration_tests
    • compliance_test_13
    • compliance_test_14
    • compliance_test_20
  • Appropriate changes to README are included in PR

@google-cla
Copy link

google-cla bot commented Oct 19, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Oct 19, 2023
@rkawajiri rkawajiri changed the title use format_table for quotes use format_table for table name Oct 19, 2023
@rkawajiri rkawajiri changed the title use format_table for table name DDLCompiler: use format_table for table name Oct 19, 2023
@rkawajiri rkawajiri changed the title DDLCompiler: use format_table for table name DDLCompiler: fix drop table quoatation bug Oct 19, 2023
@rkawajiri rkawajiri changed the title DDLCompiler: fix drop table quoatation bug fix drop table quoatation bug Oct 19, 2023
@rkawajiri rkawajiri changed the title fix drop table quoatation bug fix: drop table compiler quoatation bug Oct 19, 2023
@rkawajiri rkawajiri closed this Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sqlalchemy.schema.DropTable compilation: Table name should be quoted by back quotes (`) on DROP TABLE
1 participant
@rkawajiri