Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add raw_download kwarg to BlobReader #668

Merged
merged 2 commits into from Dec 15, 2021
Merged

feat: add raw_download kwarg to BlobReader #668

merged 2 commits into from Dec 15, 2021

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Dec 13, 2021

  • Allow raw_download kwarg for BlobReader
  • Add unit test
  • Update docstrings for blob.open()

Fixes #666 馃

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 13, 2021
@cojenco cojenco marked this pull request as ready for review December 13, 2021 23:51
@cojenco cojenco requested review from a team as code owners December 13, 2021 23:51
andrewsg
andrewsg approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cojenco cojenco merged commit 10cdad6 into googleapis:main Dec 15, 2021
@release-please release-please bot mentioned this pull request Jan 12, 2022
Closed
@cojenco cojenco deleted the kwarg-add branch January 21, 2022 23:19
@release-please release-please bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow raw_download kwarg for BlobReader
2 participants
@cojenco @andrewsg