Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use writeable streamin example for 'download_blob_to_file' #676

Merged
merged 2 commits into from Dec 23, 2021

Conversation

micahjsmith
Copy link
Contributor

The docstring shows an example of opening a file and passing the file handle to download_blob_to_file. However, this example must be untested, as it fails. The default mode for open is read-only. Instead, the file needs to be opened in some writeable model. This PR modifies the docstring example accordingly.

@micahjsmith micahjsmith requested review from a team as code owners December 21, 2021 21:22
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Dec 21, 2021
@micahjsmith
Copy link
Contributor Author

signed CLA

@tseaver tseaver changed the title Add mode in docstring example for download_blob_to_file docs: use writeable streamin example for 'download_blob_to_file' Dec 23, 2021
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 23, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 23, 2021
@tseaver tseaver merged commit 96092d4 into googleapis:main Dec 23, 2021
@micahjsmith micahjsmith deleted the patch-1 branch December 23, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants