feat: orchestrate #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added "orchestrate", a tool for deterministically testing concurrent code.
google-cla
bot
added
the
cla: yes
plamut
reviewed
Aug 26, 2021
| with open(filename, "r") as pyfile: | ||
| tokens = tokenize.generate_tokens(pyfile.readline) | ||
| for type, value, start, end, line in tokens: | ||
| if type == tokenize.COMMENT and "pragma: SYNCPOINT" in value: |
There was a problem hiding this comment.
Suggestion: Let's made the check insensitive to the number of whitespace characters between "pragma:" and "SYNCPOINT"?
I can imagine somebody accidentally typing two spaces instead of one and such syncpoint would unexpectedly not work for no obvious reason.
There was a problem hiding this comment.
@plamut FWIW, that isn't how other packages use # pragma: -- coverage, for instance, uses just plain string matching.
tseaver
approved these changes
Aug 30, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 30, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [1.1.0](https://www.github.com/googleapis/python-test-utils/compare/v1.0.0...v1.1.0) (2021-08-30) ### Features * add 'orchestrate' module ([#54](https://www.github.com/googleapis/python-test-utils/issues/54)) ([ae3da1a](https://www.github.com/googleapis/python-test-utils/commit/ae3da1ab4e7cbf268d6dce60cb467ca7ed6c2c89)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
tseaver
added a commit
to googleapis/python-ndb
that referenced
this pull request
Oct 18, 2021
Migrated from this repo in this PR: googleapis/python-test-utils#54
tseaver
added a commit
to googleapis/python-ndb
that referenced
this pull request
Oct 26, 2021
Migrated from this repo in this PR: googleapis/python-test-utils#54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "orchestrate", a tool for deterministically testing concurrent
code.
Closes #53