chore: Migrate Gapic-Generator-Java to JUnit5 #2771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcf-owl-bot
bot
removed
the
owlbot:run
lqiu96
commented
May 15, 2024
JoeWang1127
approved these changes
May 16, 2024
lqiu96
force-pushed
the
gapic-generator-junit5
branch
from
8bd2a43
to
9f910ea
Compare
|
|
blakeli0
approved these changes
May 17, 2024
alicejli
approved these changes
May 17, 2024
lqiu96
added a commit
that referenced
this pull request
May 22, 2024
Fixes: #2725 # Scope This *only* modifies the unit tests inside the gapic-generator-java module. It does not modify the generated unit tests output from the generator. JUnit4 is still needed with default scope as it's used to generate the unit tests from the TestComposer: https://github.com/googleapis/sdk-platform-java/blob/96e6626eb2dda867b5d8d81f3ec706b5a995a3c2/gapic-generator-java/pom.xml#L446-L450 # Changes - Change the scope for Unit Tests from public to package-private - Parameterized tests updated to use `@ParameterizedTests` - Import updated to `org.junit.jupiter.api.*`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2725
Scope
This only modifies the unit tests inside the gapic-generator-java module. It does not modify the generated unit tests output from the generator. JUnit4 is still needed with default scope as it's used to generate the unit tests from the TestComposer:
sdk-platform-java/gapic-generator-java/pom.xml
Lines 446 to 450 in 96e6626
Changes
@ParameterizedTestsorg.junit.jupiter.api.*