feat: support Gatsby v5 #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes are needed for Gatsby v5 support.
ericapisani
added
the
type: feature
2 tasks
|
Is there a reason we need to change the minimum node version here? Could we allow odler versions so we can support older versions of Gatsby with the same plugin? |
|
We can update this to support older versions of node - when I initially opened this PR I hadn't seen what Gatsby does when an incompatible node version is used in v5 and was trying to be as safe as possible here, but based on Gatsby's very clear warning when someone is using <18 and Gatsby v5, we should be able to safely do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed for Gatsby v5 support.
As Gatsby v4 continues to be supported (although in maintenance), it is included as a valid peer dependency, and node 14 is still the minimum version.
Migration guide from Gatsby: https://www.gatsbyjs.com/docs/reference/release-notes/migrating-from-v4-to-v5/
Fixes #195
Similar to changes done in PR #196 , but I wanted to include an
.nvmrcas part of the changes and retain Gatsby v4 as a peer dependency since this is still supported by the Gatsby teamTest site incorporating these changes can be found here: https://ep-gatsby-v5.netlify.app/