New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change default value of processDynamicNodeImports
#603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Aug 4, 2021
⏱ Benchmark resultsComparing with ff051cd largeDepsEsbuild: 14s⬆️ 15.40% increase vs. ff051cd
Legend
|
ehmicky
approved these changes
Aug 4, 2021
eduardoboucas
changed the title
feat!: change default value of
feat: change default value of Sep 20, 2021
processDynamicNodeImports
processDynamicNodeImports
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
The
processDynamicNodeImports
configuration property controls whether esbuild should add a runtime shim to any imports using dynamic expressions. The feature flag in Netlify Build that controls this value has been fully rolled out to production, so we can begin its removal.This PR changes the default value of
processDynamicNodeImports
totrue
, but still allows the functionality to be switched off if the value of the property isfalse
.- Test plan
Tests updated.
- A picture of a cute animal (not mandatory but encouraged)