Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default value of processDynamicNodeImports #603

Merged
merged 3 commits into from Sep 20, 2021

Conversation

eduardoboucas
Copy link
Member

@eduardoboucas eduardoboucas commented Aug 4, 2021

- Summary

The processDynamicNodeImports configuration property controls whether esbuild should add a runtime shim to any imports using dynamic expressions. The feature flag in Netlify Build that controls this value has been fully rolled out to production, so we can begin its removal.

This PR changes the default value of processDynamicNodeImports to true, but still allows the functionality to be switched off if the value of the property is false.

- Test plan

Tests updated.

- A picture of a cute animal (not mandatory but encouraged)

f8cc66794661850608a39e78cc693558

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Aug 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2021

⏱ Benchmark results

Comparing with ff051cd

largeDepsEsbuild: 14s

⬆️ 15.40% increase vs. ff051cd

^  13.9s                           14.1s   14.2s                                                    14s   
│   ┌──┐                            ┌──┐    ┌──┐   13.5s   13.2s           13.3s   13.2s            ┌──┐  
│   |  |                   12.8s    |  |    |  |    ┌──┐    ┌──┐            ┌──┐    ┌──┐            |▒▒|  
│ ──┼──┼────────────────────┌──┐────┼──┼────┼──┼────┼──┼────┼──┼────────────┼──┼────┼──┼────────────|▒▒|──
│   |  |   11.4s            |  |    |  |    |  |    |  |    |  |   11.1s    |  |    |  |            |▒▒|  
│   |  |    ┌──┐            |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |   10.8s    |▒▒|  
│   |  |    |  |   10.1s    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |▒▒|  
│   |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@eduardoboucas eduardoboucas changed the title feat!: change default value of processDynamicNodeImports feat: change default value of processDynamicNodeImports Sep 20, 2021
@eduardoboucas eduardoboucas merged commit cdbcad2 into main Sep 20, 2021
@eduardoboucas eduardoboucas deleted the feat/process-dynamic-node-imports branch September 20, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants