feat: pnpm-style symlinking (#636) #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netlify-team-account-1
added
the
type: bug
github-actions
bot
added
the
type: feature
⏱ Benchmark resultsComparing with b105692 largeDepsEsbuild: 13s⬆️ 4.41% increase vs. b105692 Legend
largeDepsZisi: 1m 11.4s⬆️ 5.81% increase vs. b105692 Legend
|
|
@netlify-team-account-1 what's the status of this one? |
|
This is the test that was originally added a while ago to reproduce #636 (the issue we paired on). We found that this reproduction doesn't correctly capture the real issue - but the test may still be useful to prevent future bugs, so why not merge it. |
Sounds good! |
eduardoboucas
approved these changes
Sep 29, 2021
| opts: { config: { '*': { nodeBundler: bundler } } }, | ||
| }) | ||
|
|
||
| // eslint-disable-next-line import/no-dynamic-require, node/global-require |
There was a problem hiding this comment.
We'll need to remove these once we land #682.
There was a problem hiding this comment.
#682 is only about fixtures, not about test code. We could add // eslint-disable-file import/no-dynamic-require, node/global-require to the top of this file instead of line-by-line, though!
|
Curious if this also solves for this issue with regular |
|
Not sure what issue you're referring to - if there's already an issue for it in this repository, could you link it? If not, feel free to open one :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contains a reproduction test for pnpm-style symlinking, reported non-working in #636.