feat: replace precinct with esbuild #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
⏱ Benchmark resultsComparing with c28eaaf largeDepsEsbuild: 10.4s⬇️ 11.70% decrease vs. c28eaaf Legend
largeDepsZisi: 53s⬇️ 16.78% decrease vs. c28eaaf Legend
|
eduardoboucas
changed the title
package.json
Outdated
| @@ -76,7 +77,6 @@ | |||
| "p-map": "^4.0.0", | |||
| "path-exists": "^4.0.0", | |||
| "pkg-dir": "^5.0.0", | |||
| "precinct": "^8.0.0", | |||
eduardoboucas
commented
Sep 20, 2021
src/runtimes/node/list_imports.js
Outdated
| name: 'list-imports', | ||
| setup(build) { | ||
| build.onResolve({ filter: /.*/ }, (args) => { | ||
| const isImport = args.path !== path && !isBuiltinModule(args.path) |
There was a problem hiding this comment.
precinct has the includeCore property to exclude built-in Node modules, which doesn't exist in esbuild. So we use is-builtin-module to that instead.
eduardoboucas
commented
Sep 20, 2021
|
|
||
| return { | ||
| namespace: 'list-imports', | ||
| external: isImport, |
There was a problem hiding this comment.
By setting a path as external we prevent the parser from traversing it.
eduardoboucas
commented
Sep 20, 2021
| // TODO: `precinct.paperwork()` uses `fs.readFileSync()` under the hood, | ||
| // but should use `fs.readFile()` instead | ||
| const dependencies = precinct.paperwork(path, { includeCore: false }) | ||
| const dependencies = featureFlags.parseWithEsbuild |
There was a problem hiding this comment.
We'll use this feature flag to roll this out progressively. Once the rollout is complete, we can remove precinct entirely.
netlify-team-account-1
approved these changes
Sep 20, 2021
2 tasks
ehmicky
reviewed
Sep 20, 2021
ehmicky
approved these changes
Sep 20, 2021
Co-authored-by: ehmicky <ehmicky@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Replaces
precinctwith esbuild, purely for its parsing capabilities, in the legacy bundler flow.Closes https://github.com/netlify/pod-serverless/issues/39.
- Test plan
N/A
- A picture of a cute animal (not mandatory but encouraged)