Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit nodeModulesWithDynamicImports to unresolved imports #671

Merged
merged 3 commits into from Sep 27, 2021

Conversation

eduardoboucas
Copy link
Member

- Summary

Only adds modules to nodeModulesWithDynamicImports when the imports can't be resolved. More details in the linked issue.

Closes #627

- Test plan

Adjusted existing test

- A picture of a cute animal (not mandatory but encouraged)

seal-pup-waving-norfolk-beach-3-5e09b65aaaa2b__700

@eduardoboucas eduardoboucas added the type: bug code to address defects in shipped code label Sep 24, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Sep 24, 2021

⏱ Benchmark results

Comparing with d646be2

largeDepsEsbuild: 12.4s

⬇️ 4.65% decrease vs. d646be2

^                                                  13.9s   13.9s                           14.1s          
│                  13.6s           13.7s            ┌──┐    ┌──┐                            ┌──┐          
│          12.4s    ┌──┐    13s     ┌──┐            |  |    |  |                   12.8s    |  |   12.4s  
│ ──────────┌──┐────┼──┼────┌──┐────┼──┼────────────┼──┼────┼──┼────────────────────┌──┐────┼──┼────┌──┐──
│  11.3s    |  |    |  |    |  |    |  |            |  |    |  |   11.4s            |  |    |  |    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |   10.3s    |  |    |  |    ┌──┐            |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |   10.1s    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsZisi: 1m 8.2s

⬇️ 3.17% decrease vs. d646be2

^                                                 1m 13.5s1m 14.3s                                        
│                 1m 10.3s        1m 11.6s          ┌──┐    ┌──┐                          1m 10.9s        
│         1m 7.4s   ┌──┐   1m 8s    ┌──┐            |  |    |  |                  1m 7.8s   ┌──┐  1m 8.2s 
│ ──────────┌──┐────┼──┼────┌──┐────┼──┼────────────┼──┼────┼──┼────────────────────┌──┐────┼──┼────┌──┐──
│           |  |    |  |    |  |    |  |            |  |    |  |                    |  |    |  |    |▒▒|  
│  56.5s    |  |    |  |    |  |    |  |            |  |    |  |   57.6s            |  |    |  |    |▒▒|  
│   ┌──┐    |  |    |  |    |  |    |  |   52.9s    |  |    |  |    ┌──┐   50.8s    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

@kodiakhq kodiakhq bot merged commit ce6d1ce into main Sep 27, 2021
@kodiakhq kodiakhq bot deleted the feat/filter-dynamic-imports branch September 27, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit nodeModulesWithDynamicImports to unresolved dynamic imports
2 participants