fix: improve native module detection #674

eduardoboucas · 2021-09-24T13:23:56Z

- Summary

Improves the native module detection by:

Adding node-gyp to the list of marker modules
Looking for the presence of .node files in the files array in package.json

- Test plan

Adjusted existing test.

- A picture of a cute animal (not mandatory but encouraged)

github-actions · 2021-09-24T13:26:14Z

⏱ Benchmark results

Comparing with f756b03

largeDepsEsbuild: 12.3s

⬇️ 1.72% decrease vs. f756b03

^                                  13.9s   13.9s                           14.1s   14.2s                  
│  13.6s           13.7s            ┌──┐    ┌──┐                            ┌──┐    ┌──┐   13.5s          
│   ┌──┐    13s     ┌──┐            |  |    |  |                   12.8s    |  |    |  |    ┌──┐          
│ ──┼──┼────┌──┐────┼──┼────────────┼──┼────┼──┼────────────────────┌──┐────┼──┼────┼──┼────┼──┼───12.3s──
│   |  |    |  |    |  |            |  |    |  |   11.4s            |  |    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |            |  |    |  |    ┌──┐            |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |   10.3s    |  |    |  |    |  |   10.1s    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (f756b03): 12.6s
T-29 (5bf51d0): 12.2s
T-28 (c28eaaf): 11.6s
T-27 (b843aae): 10.8s
T-26 (cdbcad2): 12.8s
T-25 (ff051cd): 11.8s
T-24 (c649c29): 12.5s
T-23 (9c628c8): 11.4s
T-22 (bf6a59b): 12.9s
T-21 (85cc47d): 13.4s
T-20 (b105692): 12.4s
T-19 (9b0c6d5): 10.6s
T-18 (53d0281): 12.2s
T-17 (b468b2a): 11.1s
T-16 (a9b86e2): 11.1s
T-15 (4c64157): 11.5s
T-14 (fbcb80f): 11.3s
T-13 (cde6c63): 12.4s
T-12 (c1e762d): 13.6s
T-11 (cc48969): 13s
T-10 (ce3c162): 13.7s
T-9 (fc6b3ef): 10.3s
T-8 (cde4e51): 13.9s
T-7 (cde2295): 13.9s
T-6 (e463691): 11.4s
T-5 (ecb8856): 10.1s
T-4 (73456ff): 12.8s
T-3 (452f7ee): 14.1s
T-2 (fcc82b7): 14.2s
T-1 (0862f9a): 13.5s
T (current commit): 12.3s

largeDepsZisi: 1m 6.3s

⬇️ 1.47% decrease vs. f756b03

^                                 1m 13.5s1m 14.3s                                1m 14.8s                
│ 1m 10.3s        1m 11.6s          ┌──┐    ┌──┐                          1m 10.9s  ┌──┐  1m 11.3s        
│   ┌──┐   1m 8s    ┌──┐            |  |    |  |                  1m 7.8s   ┌──┐    |  |    ┌──┐  1m 6.3s 
│ ──┼──┼────┌──┐────┼──┼────────────┼──┼────┼──┼────────────────────┌──┐────┼──┼────┼──┼────┼──┼────┌──┐──
│   |  |    |  |    |  |            |  |    |  |                    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |            |  |    |  |   57.6s            |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |   52.9s    |  |    |  |    ┌──┐   50.8s    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T

Legend

T-30 (f756b03): 1m 7.3s
T-29 (5bf51d0): 1m 5.8s
T-28 (c28eaaf): 1m 1.9s
T-27 (b843aae): 56.7s
T-26 (cdbcad2): 1m 9s
T-25 (ff051cd): 1m 2.2s
T-24 (c649c29): 1m 4.8s
T-23 (9c628c8): 57.8s
T-22 (bf6a59b): 1m 10.4s
T-21 (85cc47d): 1m 10.1s
T-20 (b105692): 1m 7.2s
T-19 (9b0c6d5): 58s
T-18 (53d0281): 1m 5.7s
T-17 (b468b2a): 59.1s
T-16 (a9b86e2): 57.6s
T-15 (4c64157): 58s
T-14 (fbcb80f): 56.5s
T-13 (cde6c63): 1m 7.4s
T-12 (c1e762d): 1m 10.3s
T-11 (cc48969): 1m 8s
T-10 (ce3c162): 1m 11.6s
T-9 (fc6b3ef): 52.9s
T-8 (cde4e51): 1m 13.5s
T-7 (cde2295): 1m 14.3s
T-6 (e463691): 57.6s
T-5 (ecb8856): 50.8s
T-4 (73456ff): 1m 7.8s
T-3 (452f7ee): 1m 10.9s
T-2 (fcc82b7): 1m 14.8s
T-1 (0862f9a): 1m 11.3s
T (current commit): 1m 6.3s

ehmicky · 2021-09-24T13:48:25Z

src/runtimes/node/native_modules/detector.js

-  )
+const { extname } = require('path')
+
+const markerModules = ['bindings', 'nan', 'node-gyp', 'node-gyp-build', 'node-pre-gyp', 'prebuild']


Much better than a bunch of ||!

eduardoboucas added 3 commits September 24, 2021 14:12

fix: add node-gyp to native module detection

c866e3d

feat: detect modules with native file

cd37ec3

chore: doh

9a85873

eduardoboucas added the type: bug code to address defects in shipped code label Sep 24, 2021

eduardoboucas requested a review from ehmicky September 24, 2021 13:37

ehmicky reviewed Sep 24, 2021

View reviewed changes

ehmicky approved these changes Sep 24, 2021

View reviewed changes

eduardoboucas merged commit 2de5426 into main Sep 27, 2021

eduardoboucas deleted the fix/native-module-detection branch September 27, 2021 10:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve native module detection #674

fix: improve native module detection #674

eduardoboucas commented Sep 24, 2021

github-actions bot commented Sep 24, 2021

ehmicky Sep 24, 2021

fix: improve native module detection #674

fix: improve native module detection #674

Conversation

eduardoboucas commented Sep 24, 2021

github-actions bot commented Sep 24, 2021

⏱ Benchmark results

largeDepsEsbuild: 12.3s

largeDepsZisi: 1m 6.3s

ehmicky Sep 24, 2021

Choose a reason for hiding this comment