New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: force esbuild target in zisi #681
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⏱ Benchmark resultsComparing with 12a08ba largeDepsZisi: 1m 11.3s⬇️ 0.37% decrease vs. 12a08ba
Legend
|
ehmicky
approved these changes
Sep 27, 2021
netlify-team-account-1
approved these changes
Sep 28, 2021
@@ -0,0 +1 @@ | |||
module.exports = 'jam' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🇯🇲
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
When parsing files with esbuild to find dependencies, we rely on the default
target
property set by esbuild, which isesnext
. However, this is overridden by anycompilerOptions.target
property set in atsconfig.json
. When this value is set toes5
, parsing with esbuild can fail because some expressions can't be lowered to ES5.This PR explicitly sets
target: "esnext"
in esbuild so that no transpiling is required.- Test plan
Added a new test.
- A picture of a cute animal (not mandatory but encouraged)