New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: set default Rust toolchain #715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
added
the
type: feature
code contributing to the implementation of a feature and/or user facing functionality
label
Oct 8, 2021
⏱ Benchmark resultsComparing with 67961ee largeDepsEsbuild: 12.9s⬇️ 0.73% decrease vs. 67961ee
Legend
largeDepsZisi: 1m 11.7s⬇️ 2.48% decrease vs. 67961ee
Legend
|
eduardoboucas
changed the title
feat: use RUSTUP_TOOLCHAIN env var
feat: set default Rust toolchain
Oct 10, 2021
netlify-team-account-1
approved these changes
Oct 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
type: feature
code contributing to the implementation of a feature and/or user facing functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
Before installing the Rust build target, sets the default toolchain to
stable
via therustup default
command. Because this is the one with less precedence out of all the override methods, users still have the option to specify a different toolchain using any of the other four methods.- Test plan
Adjusted existing test.
- A picture of a cute animal (not mandatory but encouraged)