Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency @vercel/nft to ^0.17.0 #765

Merged
merged 4 commits into from Oct 26, 2021

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 25, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@vercel/nft ^0.15.1 -> ^0.17.0 age adoption passing confidence

Release Notes

vercel/nft

v0.17.0

Compare Source

Minor Changes
  • Remove emit cache in favor of ensuring all parents are added in reasons: #​240

v0.16.1

Compare Source

Patches
  • Fix caching with processed emitDependency: #​239

v0.16.0

Compare Source

Minor Changes
  • Add emitDependency caching and fix pnpm symlinks: #​238
Patches
  • Removed unnecessary sentence: d568f9a

Configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by WhiteSource Renovate. View repository job log here.

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 25, 2021
@github-actions github-actions bot added the type: bug code to address defects in shipped code label Oct 25, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2021

⏱ Benchmark results

Comparing with 3c982bd

largeDepsEsbuild: 7s

⬇️ 11.03% decrease vs. 3c982bd

^                                                          14.8s                                          
│                                                           ┌──┐                                          
│                          13.4s                            |  |                                          
│                  12.6s    ┌──┐                            |  |   12.6s                   12.6s          
│                   ┌──┐    |  |                            |  |    ┌──┐           11.6s    ┌──┐          
│           11s     |  |    |  |   11.2s   11.1s   11.5s    |  |    |  |   10.8s    ┌──┐    |  |          
│ ──────────┌──┐────┼──┼────┼──┼────┌──┐────┌──┐────┌──┐────┼──┼────┼──┼────┌──┐────┼──┼────┼──┼──────────
│           |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│           |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│   7.8s    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│   ┌──┐    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |          
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |     7s   
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

largeDepsZisi: 56.4s

⬇️ 12.60% decrease vs. 3c982bd

^                                                         1m 23.6s                                        
│                         1m 17.4s                          ┌──┐                                          
│                           ┌──┐                            |  |                                          
│                 1m 11.3s  |  |                            |  |  1m 12.7s                1m 9.3s         
│ 1m 5.5s           ┌──┐    |  |                            |  |    ┌──┐                    ┌──┐          
│ ──┌──┐──1m 3.3s───┼──┼────┼──┼──1m 2.5s─────────1m 1.8s───┼──┼────┼──┼──────────1m 3.5s───┼──┼──────────
│   |  |    ┌──┐    |  |    |  |    ┌──┐  1m 0.1s   ┌──┐    |  |    |  |  1m 0.5s   ┌──┐    |  |   56.4s  
│   |  |    |  |    |  |    |  |    |  |    ┌──┐    |  |    |  |    |  |    ┌──┐    |  |    |  |    ┌──┐  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
│   |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |  |    |▒▒|  
└───┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴────┴──┴──>
    T-12    T-11    T-10    T-9     T-8     T-7     T-6     T-5     T-4     T-3     T-2     T-1      T    
Legend

kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 25, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 25, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 25, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 25, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 25, 2021
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 26, 2021
@netlify-team-account-1
Copy link
Contributor

@eduardoboucas I resolved type errors, but there are two breaking tests regarding checksum determinism and listFunctions() output. You have more context on NFT, I think it's best if you take a look at this (would also be happy to pair and learn more about NFT!).

@eduardoboucas
Copy link
Member

@netlify-team-account-1 I fixed it in e451ffe.

One of the failures was caused by a test asserting a list of files taking the order into account, which shouldn't be the case.

The other was fixed by sorting srcFiles when using NFT (as we do for other bundlers) to ensure that the archive is deterministic.

@kodiakhq kodiakhq bot merged commit 14c19f1 into main Oct 26, 2021
@kodiakhq kodiakhq bot deleted the renovate/vercel-nft-0.x branch October 26, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants