Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitise package.json files field #800

Merged
merged 2 commits into from Nov 9, 2021

Conversation

netlify-team-account-1
Copy link
Contributor

- Summary

Some packages have a malformed files field. This PR adds sanitisation to catch that.

- Test plan

  • added unit test

- A picture of a cute animal (not mandatory but encouraged)

@github-actions github-actions bot added the type: bug code to address defects in shipped code label Nov 9, 2021
eduardoboucas
eduardoboucas previously approved these changes Nov 9, 2021
Copy link
Member

@eduardoboucas eduardoboucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
src/runtimes/node/utils/package_json.ts Outdated Show resolved Hide resolved
Co-authored-by: Eduardo Bouças <mail@eduardoboucas.com>
@netlify-team-account-1 netlify-team-account-1 merged commit 6c82ada into main Nov 9, 2021
@netlify-team-account-1 netlify-team-account-1 deleted the sanitise-package-json-files branch November 9, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug code to address defects in shipped code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants