fix: esm imports with node: prefix on esbuild

[netlify-team-account-1]

- Summary

fixes a bundling error that occurs when esbuild bundles a node:-namespaced esm import.

cc nuxt/nuxt#12764

- Test plan

- A picture of a cute animal (not mandatory but encouraged)

[eduardoboucas]

Looks great! Added just a tiny comment.

[eduardoboucas]

🎸

[github-actions]

⏱ Benchmark results

largeDepsEsbuild: 7.7s

^   7.7s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    

Legend

• T (current commit): 7.7s

largeDepsNft: 50.2s

^  50.2s  
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    

Legend

• T (current commit): 50.2s

largeDepsZisi: 1m 4.5s

^ 1m 4.5s 
│   ┌──┐  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
│   |▒▒|  
└───┴──┴──>
     T    

Legend

• T (current commit): 1m 4.5s

[hrishikesh-k]

Hey team, is this supposed to be working fine in Netlify CLI?

I was testing a repo and got the exact same error in CLI, except the user is using Vite and not Nuxt.js.

EDIT: Their netlify.toml is using esbuild, so it doesn't seem like a zip-it-ship-it problem. I'll take this to the CLI team.

[netlify-team-account-1]

It's indeed a ZISI problem, which uses esbuild internally. It's expected that this error occurs in the CLI until we ship a new version of that.