fix: ensure directories are created before writing files #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoboucas
commented
Nov 17, 2021
| @@ -86,6 +88,16 @@ const resolveFunctionsDirectories = (input: string | string[]) => { | |||
| return absoluteDirectories | |||
| } | |||
|
|
|||
| const mkdirAndWriteFile: typeof pWriteFile = async (path, ...params) => { | |||
| if (typeof path === 'string') { | |||
There was a problem hiding this comment.
Checking that path is a string because it can also be a file descriptor.
There was a problem hiding this comment.
If it is a file descriptor, shouldn't pWriteFile() be used instead of mkdirAndWriteFile() then?
There was a problem hiding this comment.
Absolutely, but we still need to account for the possibility that someone decides to use mkdirAndWriteFile with a file descriptor. If nothing else, TypeScript forces us to have this check since we're setting mkdirAndWriteFile to have the same type as pWriteFile.
lukasholzer
reviewed
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
When using
archiveFormat: "none", any files inrewritesare written to disk usingwriteFile. When doing this, we must ensure that the directory structure exists prior to the write operation. This PR addresses that.- Test plan
Added a new test.
- A picture of a cute animal (not mandatory but encouraged)