Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Pattern Lab Core #1488

Open
JosefBredereck opened this issue Feb 12, 2023 · 3 comments
Open

Rewrite Pattern Lab Core #1488

JosefBredereck opened this issue Feb 12, 2023 · 3 comments

Comments

@JosefBredereck
Copy link
Contributor

JosefBredereck commented Feb 12, 2023

Intro

Pattern lab was written in 2016 and improved over time when we added more and more features but never questioned the architecture. Therefore, the core has grown and got complicated over time, since we have no concrete typing and a complicated structure where everything gets generated asynchronously.

Idea

The basic idea is to rewrite the core in typescript where the types of patterns, of an engine, of pattern lab's main file and the config are present. To ensure, third-party developers can easily enhance pattern lab and know which properties are available.

We need a way to greatly reduce the complexity and at best make use of something providing features that are focussed on scalability.

Resolutions

I would like to introduce a framework like nest JS which will give us all the scalable business application functionalities that angular provides in frontend but for node applications. We could greatly benefit from its service-based architecture and module provision.

Personally, I did not work with it yet, but I think it would be a great learning opportunity.
Still, I'm open to other Ideas and as soon as I start on that topic I will look into other alternatives and technologies.

Steps

  1. Migrate to TypeScript
  2. Migrate current feature set to new architecture, so it works as before (at least)
  3. Revisit functionalities that could be removed
  4. Rework functionalities that need improvement since a long time
@JosefBredereck JosefBredereck changed the title Rewrite Code Rewrite Pattern Lab Core Feb 12, 2023
@StfBauer
Copy link
Contributor

Will it come with ootb typescript too?

@JosefBredereck
Copy link
Contributor Author

Will it come with ootb typescript too?

Do you have anything specific in mind?
I assume ootb means out of the box?

@StfBauer
Copy link
Contributor

When I write a script in pattern lab, I can only use javascript atm. If I like to use typescript, I need to configure this on top of the pattern lab.

Wouldn't be nice when there is a ts file inside the sources, it gets automatically transpiled?

Just thinking out loud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants