Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether Google OAuth URL is deprecated #2

Closed
CremboC opened this issue Jan 18, 2019 · 1 comment
Closed

Check whether Google OAuth URL is deprecated #2

CremboC opened this issue Jan 18, 2019 · 1 comment

Comments

@CremboC
Copy link
Contributor

CremboC commented Jan 18, 2019

https://github.com/permutive/fs2-google-pubsub/blob/d70fc53535e4eeaf3da2b83e9c08d664c9ce4b52/fs2-google-pubsub-http/src/main/scala/com/permutive/pubsub/http/oauth/GoogleOAuth.scala#L34

Allegedly the above URL is deprecated and we should use https://oauth2.googleapis.com/token. I can't find anything exact and all Google documentation regarding this endpoint have disappearing from the Cloud documentation.

I found grahamearley/FirestoreGoogleAppsScript#43 which solves authentication problems (which we, as of writing this, don't have) by simply changing the URL.

@alejandrohdezma
Copy link
Contributor

This is now not an issue on this library since it doesn't handle authentication. However the underlying issue has been fixed on the library to control authentication (gcp-auth).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants