Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad/not enough Japanese translation #1617

Closed
hogashi opened this issue Apr 10, 2020 · 3 comments
Closed

Bad/not enough Japanese translation #1617

hogashi opened this issue Apr 10, 2020 · 3 comments
Labels

Comments

@hogashi
Copy link
Contributor

hogashi commented Apr 10, 2020

must

  • It seems that the translation for "Given" in Japanese is wrong:
    "Argument: %s, Given: %s, Choices: %s": "引数は %s です。指定できるのは %s つです。選択してください: %s",
    • 指定できるのは %s つです。 means "you can give %s" ( %s is expected to be the number of option such as 1, 2, 3)
    • It should be 与えられた値: %s which means "the value that you gave me: %s"

may

  • The word correspond to "value" is missing in Japanese:

    yargs/locales/ja.json

    Lines 25 to 26 in 262e796

    "one": "引数が見つかりません: %s",
    "other": "引数が見つかりません: %s"
    • 引数が見つかりません: %s only means "I can't find the argument: %s"
    • It should be 引数の値が見つかりません: %s which means "I can't find the value of the argument: %s"
  • The word "deprecated" is not translated yet.
    • deprecated should be 非推奨 which means "not recommended"
    • deprecated: %s should be 非推奨: %s which means "%s is not recommended"
@mleguen
Copy link
Member

mleguen commented Apr 10, 2020

@hogashi Thank you for pointing this out. Would it be possible for you to fix this file and submit a PR?

@mleguen mleguen added the bug label Apr 10, 2020
@hogashi
Copy link
Contributor Author

hogashi commented Apr 10, 2020

@mleguen Thank you for your reply, too. Yes, I will submit PR for this!

@hogashi
Copy link
Contributor Author

hogashi commented Apr 10, 2020

@mleguen I have just made a PR for this issue. Would you please take a look? #1619

@bcoe bcoe closed this as completed Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants