New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(): add examples #1682
feat(): add examples #1682
Conversation
add function to add multiple examples at once
I like this idea 👍 I think I would rather we overrode Thank you for the contribution. |
as @bcoe [suggested](#1682 (comment)) merge the functions to one that either accepts an array or 2 strings
@bcoe Fixed it in the latest commit |
return to this project style format
@bcoe I recommend you would squash this PR (it contain lots oh I forgot something commit 😬) |
@rluvaton no worries, we always squash 😄 |
Update the header as requested in the review
@rluvaton thank you for the contribution. |
@bcoe when this feature should be release? |
@rluvaton if you have a few moments, mind testing out a pre-release of this feature:
I'll release soon if things are looking good. |
I tried it and it looks good so far (except the missing type definition for the new feature [obviously]) |
@rluvaton okay, |
add function to add multiple examples at once
#1683