Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for async builder #1888

Merged
merged 7 commits into from Mar 26, 2021
Merged

feat: adds support for async builder #1888

merged 7 commits into from Mar 26, 2021

Conversation

bcoe
Copy link
Member

@bcoe bcoe commented Mar 14, 2021 •
edited

Fixes: #1042
BREAKING CHANGE: providing an async builder will now cause yargs to return async result
BREAKING CHANGE: .positional() now allowed at root level of yargs.

@bcoe bcoe mentioned this pull request Mar 26, 2021
Closed
@bcoe bcoe merged commit ade29b8 into master Mar 26, 2021
@bcoe bcoe deleted the async-builder branch March 26, 2021 22:34
@bcoe bcoe mentioned this pull request Apr 3, 2021
Merged
bcoe added a commit that referenced this pull request Apr 3, 2021
@bcoe
fix(async): don't call parse callback until async ops complete (#1896)
a93f5ff 
If a callback is provided to parse() it will now be executed after all promises have resolved.

The cause of #1888, was that this[kUnfreeze](); was being called too soon, which set this.#parseFn to null.

Fixes #1888
This was referenced Nov 25, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow command builder to accept a promise
1 participant
@bcoe