update interceptor logging for PCU #1097
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1097 +/- ##
=============================================
+ Coverage 70.75% 81.55% +10.79%
- Complexity 1571 1790 +219
=============================================
Files 100 102 +2
Lines 7859 7916 +57
Branches 967 974 +7
=============================================
+ Hits 5561 6456 +895
+ Misses 1886 1057 -829
+ Partials 412 403 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
arunkumarchacko
approved these changes
Jan 5, 2024
| private void updateUploadId(@Nonnull String uploadId) { | ||
| if (streamUploadId == null) { | ||
| private void updateStreamUploadId(@Nonnull String uploadId) { | ||
| if (Strings.isNullOrEmpty(streamUploadId) && !Strings.isNullOrEmpty(uploadId)) { |
There was a problem hiding this comment.
I guess streamUploadId and uploadId cannot be null?
|
|
||
| logRecords | ||
| .put(GoogleCloudStorageTracingFields.WRITE_OFFSET.name, request.getWriteOffset()) | ||
| .put(GoogleCloudStorageTracingFields.FINALIZE_WRITE.name, request.getFinishWrite()) |
There was a problem hiding this comment.
FInish write is same as finalizewrite?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed below 2 issues:
PCU had issue in logging
nulluploadIds.nullvalue.In Direct uploads incocationIds were gettign logged as
NOT-FOUND.streamCreatedto update the Ids for tracing but there are cases when actual stream creation is delayed and sometimes even happened afteronMessageis called . Updated the logic of updatign invocationid in tracers by updating it as soon as we get the request to start the tracer i.e.SimpleForwardingClientCall.start.Added integration test to very the tracing for PCU calls.